Skip to contentSkip to conversation

Override 80-wire cable detection for Toshiba S1800-814

PATCH In review Daniel Exner 3 participants 4 messages Aug 29, 2007 – Sep 5, 2007 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Override 80-wire cable detection for Toshiba S1800-814

Hi!

Please CC me, as I'm currently not subscribed to this list, thx.

Attached patch will add above mentioned Laptop Model to whitelist for both pata_ali and alim15x3, as it is correctly detected as 40-wire connected but this cable is short enough to still do transfers higher than UDMA33. Don't know if this is also true for other S1800 Laptops cause I own only one.

I hope I did this correctly as this is my first Patch Mail to LKML :)

Signature · 2 lines
Greetings
Daniel Exner
drivers/ata/pata_ali.c +7 -0
@@ -48,6 +48,13 @@
 			DMI_MATCH(DMI_BOARD_VERSION, "OmniBook N32N-736"),
 		},
 	},
+	{
+		.ident = "Toshiba Satelite S1800-814",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "S1800-814"),
+		},
+	}, 
 	{ }
 };
 
drivers/ide/pci/alim15x3.c +7 -0
@@ -596,6 +596,13 @@
 			DMI_MATCH(DMI_BOARD_VERSION, "OmniBook N32N-736"),
 		},
 	},
+	{
+		.ident = "Toshiba Satellite S1800-814",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "S1800-814"),
+		},
+	},
 	{ }
 };
 
#1 lore raw
Quoted 8 lines · On Wed, 29 Aug 2007 23:41:13 +0200 Daniel Exner <[email protected]> wrote:

Hi!

Please CC me, as I'm currently not subscribed to this list, thx.

Attached patch will add above mentioned Laptop Model to whitelist for both pata_ali and alim15x3, as it is correctly detected as 40-wire connected but this cable is short enough to still do transfers higher than UDMA33. Don't know if this is also true for other S1800 Laptops cause I own only one.

Looks good to me - does need a Signed-off-by: line however

#2 lore raw

PATCH 1/1 Override 80-wire cable detection for Toshiba S1800-814 (resend)

Hi!

Please CC me, as I'm currently not subscribed to this list, thx.

Another try :)

Signature · 2 lines
Greetings
Daniel Exner

Add Toshiba S1800-814 to whitelist for both
pata_ali and alim15x3, as it is correctly detected as 40-wire connected but this cable is short enough to still use transfer modes higher than UDMA33.

drivers/ata/pata_ali.c +7 -0
@@ -48,6 +48,13 @@
 			DMI_MATCH(DMI_BOARD_VERSION, "OmniBook N32N-736"),
 		},
 	},
+	{
+		.ident = "Toshiba Satelite S1800-814",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "S1800-814"),
+		},
+	}, 
 	{ }
 };
 
drivers/ide/pci/alim15x3.c +7 -0
@@ -596,6 +596,13 @@
 			DMI_MATCH(DMI_BOARD_VERSION, "OmniBook N32N-736"),
 		},
 	},
+	{
+		.ident = "Toshiba Satellite S1800-814",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "S1800-814"),
+		},
+	},
 	{ }
 };
 
#3 lore raw

Re: [PATCH] Override 80-wire cable detection for Toshiba S1800-814 (resend)

Quoted 3 lines · Daniel Exner

Hi!

Please CC me, as I'm currently not subscribed to this list, thx.

applied but please inline patches instead of attaching them next time (makes it much easier to review/apply them)