Skip to contentSkip to conversation

Makefile: Add cache-tree.h to the public headers list

PATCH In review Dmitry V. Levin 2 participants 3 messages Jun 15, 2016 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 3/3 Makefile: Add cache-tree.h to the public headers list

Some external projects (e.g. parsecvs) need cache-tree.h file.

---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Makefile +1 -1
index d50e30b..2b04829 100644
@@ -283,7 +283,7 @@ LIB_FILE=libgit.a
 XDIFF_LIB=xdiff/lib.a
 
 LIB_H = \
-	archive.h blob.h cache.h commit.h csum-file.h delta.h grep.h \
+	archive.h blob.h cache.h cache-tree.h commit.h csum-file.h delta.h grep.h \
 	diff.h object.h pack.h pkt-line.h quote.h refs.h list-objects.h sideband.h \
 	run-command.h strbuf.h tag.h tree.h git-compat-util.h revision.h \
 	tree-walk.h log-tree.h dir.h path-list.h unpack-trees.h builtin.h \
Signature · 1 line
ldv
#1 lore raw
Quoted 1 line · Dmitry V. Levin

Some external projects (e.g. parsecvs) need cache-tree.h file.

Your patch shows that our Makefile has been lacking a necessary dependency for a long time. LIB_H is not "public headers list", but more like "the headers everybody depends on", and the header file should have been on that list. Thanks.

I am however not convinced it is a good idea to treat libgit.a as if it is a library. It is not a library in the usual sense of the word. Originally we did libgit.a primarily so that we do not have to list all the *.o dependencies in the Makefile out of laziness ;-)

#2 lore raw

On Wed, Sep 05, 2007 at 05:16:47PM -0700, Junio C Hamano wrote:
[...]

Quoted 3 lines

I am however not convinced it is a good idea to treat libgit.a as if it is a library.
It is not a library in the usual sense of the word.

I'd certainly prefer libgit.so with stable interface instead, but parsecvs needs -lgit now, it cannot wait for "good library".

Signature · 1 line
ldv