ide: add IDE_HFLAG_ERROR_STOPS_FIFO host flag

Add IDE_HFLAG_ERROR_STOPS_FIFO host flag and use it instead of hwif->err_stops_fifo. As a side-effect this change fixes hwif->err_stops_fifo not being restored by ide_hwif_restore().

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

---
 drivers/ide/ide-io.c           |    3 ++-
 drivers/ide/pci/pdc202xx_new.c |    3 +--
 drivers/ide/pci/pdc202xx_old.c |    8 ++++----
 include/linux/ide.h            |    3 ++-
 4 files changed, 9 insertions(+), 8 deletions(-)

Quoted 5 lines · Bartlomiej Zolnierkiewicz

Add IDE_HFLAG_ERROR_STOPS_FIFO host flag and use it instead of hwif->err_stops_fifo. As a side-effect this change fixes hwif->err_stops_fifo not being restored by ide_hwif_restore().

Quoted 7 lines

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

---
 drivers/ide/ide-io.c           |    3 ++-
 drivers/ide/pci/pdc202xx_new.c |    3 +--
 drivers/ide/pci/pdc202xx_old.c |    8 ++++----
 include/linux/ide.h            |    3 ++-
 4 files changed, 9 insertions(+), 8 deletions(-)

Hum, I wonder if libata needs something like this.

Quoted 12 lines · On Thu, 6 Sep 2007 04:13:56 -0400 Jeff Garzik <[email protected]> wrote:

Quoted 11 lines · Bartlomiej Zolnierkiewicz

Add IDE_HFLAG_ERROR_STOPS_FIFO host flag and use it instead of hwif->err_stops_fifo. As a side-effect this change fixes hwif->err_stops_fifo not being restored by ide_hwif_restore().

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

---
 drivers/ide/ide-io.c           |    3 ++-
 drivers/ide/pci/pdc202xx_new.c |    3 +--
 drivers/ide/pci/pdc202xx_old.c |    8 ++++----
 include/linux/ide.h            |    3 ++-
 4 files changed, 9 insertions(+), 8 deletions(-)

Quoted 1 line

Hum, I wonder if libata needs something like this.

You'd have to add the drain data on error hack first, right now we will reset in that case (which for one or two devices has another problem in that it won't clear a stuck FIFO)

Quoted 3 lines

You'd have to add the drain data on error hack first, right now we will reset in that case (which for one or two devices has another problem in that it won't clear a stuck FIFO)

Nod. There was nothing ever wrong with Mark's drain patch, I just never saw a solid justification for it outside of root

Quoted 4 lines

Quoted 3 lines

You'd have to add the drain data on error hack first, right now we will reset in that case (which for one or two devices has another problem in that it won't clear a stuck FIFO)

Nod. There was nothing ever wrong with Mark's drain patch, I just never saw a solid justification for it outside of root

You don't need to be root, any user can do this with the right commands via SG_IO - and it happens on errors occassionally for real.

Quoted 8 lines · Alan Cox

Quoted 5 lines

Quoted 3 lines

You'd have to add the drain data on error hack first, right now we will reset in that case (which for one or two devices has another problem in that it won't clear a stuck FIFO)

Nod. There was nothing ever wrong with Mark's drain patch, I just never saw a solid justification for it outside of root

You don't need to be root, any user can do this with the right commands via SG_IO - and it happens on errors occassionally for real.

Which commands?