Skip to contentSkip to conversation

dgrs: sparse warnings

PATCH In review Stephen Hemminger 2 participants 5 messages Sep 6, 2007

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Stephen Hemminger

author
#0 lore raw

The dgrs driver is crap and assumes direct access to PCI iomem.

CHECK drivers/net/dgrs.c
drivers/net/dgrs.c:314:20: warning: cast removes address space of expression drivers/net/dgrs.c:330:12: warning: incorrect type in argument 1 (different address spaces)
drivers/net/dgrs.c:330:12: expected void volatile [noderef] <asn:2>*addr
drivers/net/dgrs.c:330:12: got void *<noident>
drivers/net/dgrs.c:1003:14: warning: incorrect type in assignment (different address spaces)
drivers/net/dgrs.c:1003:14: expected char *[usertype] vmem
drivers/net/dgrs.c:1003:14: got void [noderef] <asn:2>*
drivers/net/dgrs.c:1023:17: warning: incorrect type in argument 1 (different address spaces)
drivers/net/dgrs.c:1023:17: expected void volatile [noderef] <asn:2>*addr
drivers/net/dgrs.c:1023:17: got char *[usertype] vmem
drivers/net/dgrs.c:1052:16: warning: incorrect type in argument 1 (different address spaces)
drivers/net/dgrs.c:1052:16: expected void volatile [noderef] <asn:2>*addr
drivers/net/dgrs.c:1052:16: got char *[usertype] vmem
drivers/net/dgrs.c:1106:16: warning: incorrect type in argument 1 (different address spaces)
drivers/net/dgrs.c:1106:16: expected void volatile [noderef] <asn:2>*addr
drivers/net/dgrs.c:1106:16: got char *[usertype] vmem
drivers/net/dgrs.c:1369:15: warning: incorrect type in argument 1 (different address spaces)
drivers/net/dgrs.c:1369:15: expected void volatile [noderef] <asn:2>*addr
drivers/net/dgrs.c:1369:15: got char *[usertype] vmem
drivers/net/dgrs.c:1371:12: warning: incorrect type in argument 1 (different address spaces)
drivers/net/dgrs.c:1371:12: expected void volatile [noderef] <asn:2>*addr
drivers/net/dgrs.c:1371:12: got unsigned char [usertype] *<noident>

Perhaps we should just mark it as BROKEN in Kconfig

#1 lore raw
Quoted 2 lines · Stephen Hemminger

The dgrs driver is crap and assumes direct access to PCI iomem.

dgrs wants to be removed, it has no users.
(no bug report in bugzilla nor in debian nor in google) the firmware is not distrutable.

i'll resend my removal patch bzipped and attached.

Signature · 1 line
maks
#2 lore raw

PATCH 1/1 dgrs removal

nobody objected to adrian's rfc dropping dgrs on netdev back in dec. 2006. -> http://marc.info/?l=linux-netdev&m=116507999803538&w=2
as bonus points this will get rid of a proprietary licensed firmware.

"The dgrs driver is crap and assumes direct access to PCI iomem"
- Stephen Hemminger <[email protected]>

dgrs has no users and it's hardware was never shipped.

Signed-off-by maximilian attems <[email protected]>
Acked-by Andres Salomon <[email protected]>
Acked-by Alan <[email protected]>

find the patch attached, due to netdev size constraints with the following diffstat

 Documentation/networking/dgrs.txt    |   52 
 b/Documentation/networking/00-INDEX  |    2 
 b/MAINTAINERS                        |    6 
 b/drivers/net/Kconfig                |   15 
 b/drivers/net/Makefile               |    1 
 b/drivers/net/wireless/rtl8187_dev.c |    1 
 drivers/net/dgrs.c                   | 1615 -----
 drivers/net/dgrs.h                   |   38 
 drivers/net/dgrs_asstruct.h          |   37 
 drivers/net/dgrs_bcomm.h             |  148 
 drivers/net/dgrs_es4h.h              |  183 
 drivers/net/dgrs_ether.h             |  135 
 drivers/net/dgrs_firmware.c          | 9966 -----------------------------------
 drivers/net/dgrs_i82596.h            |  473 -
 drivers/net/dgrs_plx9060.h           |  175 
 15 files changed, 1 insertion(+), 12846 deletions(-)
Signature · 1 line
maks
#3 lore raw

Re: [patch] dgrs removal

Quoted 2 lines · maximilian attems
 b/drivers/net/wireless/rtl8187_dev.c |    1 
 15 files changed, 1 insertion(+), 12846 deletions(-)

urrgs that was not meant to be there,
resending..

Signature · 1 line
maks
Acked-by Andres Salomon Acked-by Alan
#4 lore raw

Re: [patch] dgrs removal

nobody objected to adrian's rfc dropping dgrs on netdev back in dec. 2006. -> http://marc.info/?l=linux-netdev&m=116507999803538&w=2
as bonus points this will get rid of a proprietary licensed firmware.

"The dgrs driver is crap and assumes direct access to PCI iomem"
- Stephen Hemminger <[email protected]>

dgrs has no users and it's hardware was never shipped.

Signed-off-by maximilian attems <[email protected]>
Acked-by Andres Salomon <[email protected]>
Acked-by Alan <[email protected]>

---
sorry for the resend, now with corrected diffstat

 Documentation/networking/00-INDEX |    2 
 Documentation/networking/dgrs.txt |   52 
 MAINTAINERS                       |    6 
 drivers/net/Kconfig               |   15 
 drivers/net/Makefile              |    1 
 drivers/net/dgrs.c                | 1615 ----
 drivers/net/dgrs.h                |   38 
 drivers/net/dgrs_asstruct.h       |   37 
 drivers/net/dgrs_bcomm.h          |  148 
 drivers/net/dgrs_es4h.h           |  183 
 drivers/net/dgrs_ether.h          |  135 
 drivers/net/dgrs_firmware.c       | 9966 ------------------------------
 drivers/net/dgrs_i82596.h         |  473 -
 drivers/net/dgrs_plx9060.h        |  175 
 14 files changed, 12846 deletions(-)
Signature · 1 line
maks