Skip to contentSkip to conversation

ixgbe: driver for Intel(R) 82598 PCI-Express 10GbE adapters (v4)

PATCH In review Auke Kok 4 participants 7 messages Sep 6, 2007 – Sep 12, 2007

Subsystems (2)
lore
Share & tools
lore

Auke Kok

author
#0 lore raw

PATCH 1/1 ixgbe: driver for Intel(R) 82598 PCI-Express 10GbE adapters (v4)

This patch adds support for the Intel 82598 PCI-Express 10GbE chipset. Devices will be available on the market soon.

This version of the driver is largely the same as the last release:

* Driver uses a single RX and single TX queue, each using 1 MSI-X irq vector.
* Driver runs in NAPI mode only
* Driver is largely multiqueue-ready (TM)

Changes since 20070803:
* removed wrappers for hardware functions
* incorporated e1000e-style HW api reorganization code
* sparse/checkpatch cleanups, namespace cleanups
* driver prints out extra debugging information at load time identifying adapter board number, mac, phy types
* removed ixgbe_api.c, ixgbe_api.h, ixgbe_osdep.h
* driver update to 1.1.18
* removed ixgbe.txt which contained no useful info anymore

---

 MAINTAINERS                       |   10 
 drivers/net/Kconfig               |   27 
 drivers/net/Makefile              |    1 
 drivers/net/ixgbe/Makefile        |   36 
 drivers/net/ixgbe/ixgbe.h         |  258 +++
 drivers/net/ixgbe/ixgbe_82598.c   |  589 ++++++++
 drivers/net/ixgbe/ixgbe_common.c  | 1175 +++++++++++++++
 drivers/net/ixgbe/ixgbe_common.h  |   86 +
 drivers/net/ixgbe/ixgbe_ethtool.c |  943 ++++++++++++
 drivers/net/ixgbe/ixgbe_main.c    | 2883 +++++++++++++++++++++++++++++++++++++
 drivers/net/ixgbe/ixgbe_phy.c     |  494 ++++++
 drivers/net/ixgbe/ixgbe_phy.h     |   50 +
 drivers/net/ixgbe/ixgbe_type.h    | 1332 +++++++++++++++++
 13 files changed, 7876 insertions(+), 8 deletions(-)
MAINTAINERS +4 -6
index 9c54a5e..49bea72 100644
@@ -2022,16 +2022,14 @@ W:	http://sourceforge.net/projects/e1000/
 S:	Supported
 
 INTEL PRO/10GbE SUPPORT
-P:	Jeff Kirsher
-M:	[email protected]
 P:	Ayyappan Veeraiyan
 M:	[email protected]
-P:	John Ronciak
-M:	[email protected]
-P:	Jesse Brandeburg
-M:	[email protected]
 P:	Auke Kok
 M:	[email protected]
+P:	Jesse Brandeburg
+M:	[email protected]
+P:	John Ronciak
+M:	[email protected]
 L:	[email protected]
 W:	http://sourceforge.net/projects/e1000/
 S:	Supported
drivers/net/Kconfig +25 -2
index 5b9e17b..39a91e0 100644
@@ -2420,12 +2420,35 @@ config EHEA
 	  To compile the driver as a module, choose M here. The module
 	  will be called ehea.
 
+config IXGBE
+	tristate "Intel(R) 10GbE PCI Express adapters support"
+	depends on PCI
+	---help---
+	  This driver supports Intel(R) 10GbE PCI Express family of
+	  adapters.  For more information on how to identify your adapter, go
+	  to the Adapter & Driver ID Guide at:
+
+	  <http://support.intel.com/support/network/adapter/pro100/21397.htm>
+
+	  For general information and support, go to the Intel support
+	  website at:
+
+	  <http://support.intel.com>
+
+	  More specific information on configuring the driver is in
+	  <file:Documentation/networking/ixgbe.txt>.
+
+	  To compile this driver as a module, choose M here and read
+	  <file:Documentation/networking/net-modules.txt>.  The module
+	  will be called ixgbe.
+
 config IXGB
 	tristate "Intel(R) PRO/10GbE support"
 	depends on PCI
 	---help---
-	  This driver supports Intel(R) PRO/10GbE family of
-	  adapters.  For more information on how to identify your adapter, go
+	  This driver supports Intel(R) PRO/10GbE family of adapters for
+	  PCI-X type cards. For PCI-E type cards, use the "ixgbe" driver
+	  instead. For more information on how to identify your adapter, go
 	  to the Adapter & Driver ID Guide at:
 
 	  <http://support.intel.com/support/network/adapter/pro100/21397.htm>
drivers/net/Makefile +1 -0
index e684212..7529c8f 100644
@@ -4,6 +4,7 @@
 
 obj-$(CONFIG_E1000) += e1000/
 obj-$(CONFIG_IBM_EMAC) += ibm_emac/
+obj-$(CONFIG_IXGBE) += ixgbe/
 obj-$(CONFIG_IXGB) += ixgb/
 obj-$(CONFIG_CHELSIO_T1) += chelsio/
 obj-$(CONFIG_CHELSIO_T3) += cxgb3/
drivers/net/ixgbe/Makefile new file +36 -0
new file mode 100644
index 0000000..ccd83d9
@@ -0,0 +1,36 @@
+################################################################################
+#
+# Intel 10 Gigabit PCI Express Linux driver
+# Copyright(c) 1999 - 2007 Intel Corporation.
+#
+# This program is free software; you can redistribute it and/or modify it
+# under the terms and conditions of the GNU General Public License,
+# version 2, as published by the Free Software Foundation.
+#
+# This program is distributed in the hope it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+# more details.
+#
+# You should have received a copy of the GNU General Public License along with
+# this program; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
+#
+# The full GNU General Public License is included in this distribution in
+# the file called "COPYING".
+#
+# Contact Information:
+# Linux NICS <[email protected]>
+# e1000-devel Mailing List <[email protected]>
+# Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
+#
+################################################################################
+
+#
+# Makefile for the Intel(R) 10GbE PCI Express ethernet driver
+#
+
+obj-$(CONFIG_IXGBE) += ixgbe.o
+
+ixgbe-objs := ixgbe_main.o ixgbe_common.o ixgbe_ethtool.o \
+              ixgbe_82598.o ixgbe_phy.o
drivers/net/ixgbe/ixgbe.h new file +258 -0

258 lines not on this page · raw message

drivers/net/ixgbe/ixgbe_82598.c new file +589 -0

589 lines not on this page · raw message

drivers/net/ixgbe/ixgbe_common.c new file +1175 -0

1,175 lines not on this page · raw message

drivers/net/ixgbe/ixgbe_common.h new file +86 -0

86 lines not on this page · raw message

drivers/net/ixgbe/ixgbe_ethtool.c new file +943 -0

792 lines not on this page · raw message

drivers/net/ixgbe/ixgbe_main.c new file +2883 -0

2,883 lines not on this page · raw message

drivers/net/ixgbe/ixgbe_phy.c new file +494 -0

494 lines not on this page · raw message

drivers/net/ixgbe/ixgbe_phy.h new file +50 -0

50 lines not on this page · raw message

drivers/net/ixgbe/ixgbe_type.h new file +1332 -0

1,332 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Part of the diff is not shown here. View the raw message.

maintainer
#2 lore raw

From: "Kok, Auke" <[email protected]>
Date: Thu, 06 Sep 2007 11:31:47 -0700

Quoted 7 lines

Also available through git:// and http:// here:

   http://foo-projects.org/~sofar/ixgbe-20070905-submission.patch
   http://foo-projects.org/~sofar/ixgbe-20070905-submission.patch.bz2
   (git-am formatted!)

   git://lost.foo-projects.org/~ahkok/linux-2.6 ixgbe-20070905-submission

To be honest I have absolutely no problems with this driver and we should just cut the crap and merge it in now.

Any objections anyone makes at this point is frankly nit picking crap which we can cure with followon cleanups and corrections.

#3 lore raw
Quoted 10 lines · On Thu, 06 Sep 2007 12:44:22 -0700 (PDT) David Miller <[email protected]>…

From: "Kok, Auke" <[email protected]>
Date: Thu, 06 Sep 2007 11:31:47 -0700

Quoted 6 lines

Also available through git:// and http:// here:

   http://foo-projects.org/~sofar/ixgbe-20070905-submission.patch
   http://foo-projects.org/~sofar/ixgbe-20070905-submission.patch.bz2
   (git-am formatted!)
Quoted 7 lines
Quoted 1 line
   git://lost.foo-projects.org/~ahkok/linux-2.6 ixgbe-20070905-submission

To be honest I have absolutely no problems with this driver and we should just cut the crap and merge it in now.

Any objections anyone makes at this point is frankly nit picking crap which we can cure with followon cleanups and corrections.

fyi, I've been dropping this tree because changes in the net-2.6 tree kind of wreck it.

We can merge it into Jeff's tree OK but I'll probably disable it in Kconfig and whoever merges second will have some fixing to do..

author
#4 lore raw
Quoted 14 lines · Andrew Morton
Quoted 14 lines · On Thu, 06 Sep 2007 12:44:22 -0700 (PDT) David Miller <[email protected]>…

From: "Kok, Auke" <[email protected]>
Date: Thu, 06 Sep 2007 11:31:47 -0700

Quoted 7 lines

Also available through git:// and http:// here:

   http://foo-projects.org/~sofar/ixgbe-20070905-submission.patch
   http://foo-projects.org/~sofar/ixgbe-20070905-submission.patch.bz2
   (git-am formatted!)

   git://lost.foo-projects.org/~ahkok/linux-2.6 ixgbe-20070905-submission

To be honest I have absolutely no problems with this driver and we should just cut the crap and merge it in now.

Quoted 8 lines
Quoted 2 lines

Any objections anyone makes at this point is frankly nit picking crap which we can cure with followon cleanups and corrections.

fyi, I've been dropping this tree because changes in the net-2.6 tree kind of wreck it.

We can merge it into Jeff's tree OK but I'll probably disable it in Kconfig and whoever merges second will have some fixing to do..

yes, I am already preparing to fix this up like I did for e1000e. As soon as I have something I'll post it to you and netdev for -mm

Auke

#5 lore raw
In reply to David Miller
Quoted 9 lines · David Miller

From: "Kok, Auke" <[email protected]>
Date: Thu, 06 Sep 2007 11:31:47 -0700

Quoted 6 lines

Also available through git:// and http:// here:

   http://foo-projects.org/~sofar/ixgbe-20070905-submission.patch
   http://foo-projects.org/~sofar/ixgbe-20070905-submission.patch.bz2
   (git-am formatted!)
Quoted 7 lines
Quoted 1 line
   git://lost.foo-projects.org/~ahkok/linux-2.6 ixgbe-20070905-submission

To be honest I have absolutely no problems with this driver and we should just cut the crap and merge it in now.

Any objections anyone makes at this point is frankly nit picking crap which we can cure with followon cleanups and corrections.

Are you responding to a strawman or something?

AFAICS nobody objected to it, and Auke cleaned it up a la e1000e, which got queued during KS.

Jeff

author
#6 lore raw
Quoted 10 lines · Jeff Garzik
Quoted 9 lines · David Miller

From: "Kok, Auke" <[email protected]>
Date: Thu, 06 Sep 2007 11:31:47 -0700

Quoted 6 lines

Also available through git:// and http:// here:

   http://foo-projects.org/~sofar/ixgbe-20070905-submission.patch
   http://foo-projects.org/~sofar/ixgbe-20070905-submission.patch.bz2
   (git-am formatted!)
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
   git://lost.foo-projects.org/~ahkok/linux-2.6 ixgbe-20070905-submission

To be honest I have absolutely no problems with this driver and we should just cut the crap and merge it in now.

AFAICS nobody objected to it, and Auke cleaned it up a la e1000e, which got queued during KS.

Jeff,

as of today ixgbe is ready for a possible merge with davem's net-2.6.24 - I sent you the patch earlier today as well as to David and Andrew.

Since this takes away the only obstruction that I can see that would prevent a normal merge, I would like to know if you are thinking of merging this driver for 2.6.24 or not. No pressure of course, but the approaching merge window is dooming and postponing this driver for a whole kernel version just because you accidentally missed or forgot it would be a shame.

Auke