Skip to contentSkip to conversation

Freeing alive inet6 address

PATCH In review Denis V. Lunev 2 participants 2 messages Sep 7, 2007 – Sep 11, 2007

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Freeing alive inet6 address

From: Denis V. Lunev <[email protected]>

addrconf_dad_failure calls addrconf_dad_stop which takes referenced address and drops the count. So, in6_ifa_put perrformed at out: is extra. This results in message: "Freeing alive inet6 address" and not released dst entries.

net/ipv6/ndisc.c renamed from net/ipv6/ndisc.c.ipv6dad +1 -1
@@ -736,7 +736,7 @@ static void ndisc_recv_ns(struct sk_buff
 				 * so fail our DAD process
 				 */
 				addrconf_dad_failure(ifp);
-				goto out;
+				return;
 			} else {
 				/*
 				 * This is not a dad solicitation.
maintainer
#1 lore raw

From: "Denis V. Lunev" <[email protected]>
Date: Fri, 7 Sep 2007 14:21:18 +0400

Quoted 8 lines

From: Denis V. Lunev <[email protected]>

addrconf_dad_failure calls addrconf_dad_stop which takes referenced address and drops the count. So, in6_ifa_put perrformed at out: is extra. This results in message: "Freeing alive inet6 address" and not released dst entries.

I've seen this bug myself just a week before heading to Europe for conferences and intended to look into it.

Thanks a lot for fixing this, patch applied.