Skip to contentSkip to conversation

sata & scsi suggestion for make menuconfig

DISCUSSION Al Boldi 3 participants 5 messages Sep 8, 2007 – Sep 9, 2007 SCSI

lore
Share & tools
lore

Al Boldi

author
#0 lore raw
Quoted 7 lines · Krzysztof Halasa
Quoted 3 lines

Ok, but that's not the most common situaties. What I'm suggesting is a warning or a please note popup. Not neccessarily an error or refusing to continue thing.

What IMHO makes sense is changing all references to SCSI CDROM, SCSI DISK etc. to just CDROM, DISK, and changing SCSI (menu) to something like MASS STORAGE.

I once sent a patch to make libata a submenu of scsi.

[PATCH] libata Kconfig: Allow libata to be selected from within the SCSI submenu
From: Al Boldi <[email protected]>
To: [email protected]
CC: Alan Cox <[email protected]>, [email protected]
Date: 08/01/07 07:22 am

Move libata Kconfig sourcing from the drivers Kconfig into the SCSI Kconfig.

This allows the user to quickly select additional disk/tape/cdrom support from within the same menu.

---

drivers/Kconfig 2007-08-01 06:33:13.000000000 +0300 renamed from drivers/Kconfig 2007-05-02 17:25:30.000000000 +0300 +0 -2
@@ -22,8 +22,6 @@ source "drivers/ide/Kconfig"
 
 source "drivers/scsi/Kconfig"
 
-source "drivers/ata/Kconfig"
-
 source "drivers/cdrom/Kconfig"
 
 source "drivers/md/Kconfig"
drivers/scsi/Kconfig 2007-08-01 06:46:42.000000000 +0300 renamed from drivers/scsi/Kconfig 2007-07-09 06:38:37.000000000 +0300 +2 -0
@@ -7,6 +7,8 @@ config RAID_ATTRS
        ---help---
          Provides RAID
 
+source "drivers/ata/Kconfig"
+
 config SCSI
        tristate "SCSI device support"
        depends on BLOCK

Thanks!

--
Al

#1 lore raw
Quoted 1 line

I once sent a patch to make libata a submenu of scsi.

Which is wrong

The general comments about moving this stuff around and making it clearer what sd/sr etc are nowdays are good but hiding libata under SCSI will cause even more confusion than it cures

author
#2 lore raw
Quoted 9 lines · Alan Cox
Quoted 1 line

I once sent a patch to make libata a submenu of scsi.

Which is wrong

The general comments about moving this stuff around and making it clearer what sd/sr etc are nowdays are good but hiding libata under SCSI will cause even more confusion than it cures

That's easy to fix: just change the SCSI heading to include a libata hint.

Something like this:

[PATCH] libata Kconfig: Allow libata to be selected from within the SCSI submenu

Move libata Kconfig sourcing from the drivers Kconfig into the SCSI Kconfig, and change the SCSI menu heading to indicate libata submenu inclusion.

This allows the user to quickly select additional disk/tape/cdrom support from within the same menu.

---

drivers/Kconfig 2007-08-01 06:33:13.000000000 +0300 renamed from drivers/Kconfig 2007-05-02 17:25:30.000000000 +0300 +0 -2
@@ -22,8 +22,6 @@ source "drivers/ide/Kconfig"
 
 source "drivers/scsi/Kconfig"
 
-source "drivers/ata/Kconfig"
-
 source "drivers/cdrom/Kconfig"
 
 source "drivers/md/Kconfig"
drivers/scsi/Kconfig 2007-08-01 06:46:42.000000000 +0300 renamed from drivers/scsi/Kconfig 2007-07-09 06:38:37.000000000 +0300 +3 -1
@@ -7,6 +7,8 @@ config RAID_ATTRS
        ---help---
          Provides RAID
 
+source "drivers/ata/Kconfig"
+
 config SCSI
-       tristate "SCSI device support"
+       tristate "SCSI and Libata device support"
        depends on BLOCK

Thanks!

--
Al

#3 lore raw
Quoted 5 lines · Al Boldi
Quoted 4 lines · Alan Cox
Quoted 1 line

I once sent a patch to make libata a submenu of scsi.

Which is wrong

Quoted 7 lines
Quoted 5 lines

The general comments about moving this stuff around and making it clearer what sd/sr etc are nowdays are good but hiding libata under SCSI will cause even more confusion than it cures

That's easy to fix: just change the SCSI heading to include a libata hint.

Let's not. I am perfectly fine with how things currently are, plus optionally Stefan Richter's suggestion.

Jan

author
#4 lore raw
In reply to Al Boldi
Quoted 43 lines · Al Boldi
Quoted 9 lines · Alan Cox
Quoted 1 line

I once sent a patch to make libata a submenu of scsi.

Which is wrong

The general comments about moving this stuff around and making it clearer what sd/sr etc are nowdays are good but hiding libata under SCSI will cause even more confusion than it cures

That's easy to fix: just change the SCSI heading to include a libata hint.

Something like this:

[PATCH] libata Kconfig: Allow libata to be selected from within the SCSI submenu

Move libata Kconfig sourcing from the drivers Kconfig into the SCSI Kconfig, and change the SCSI menu heading to indicate libata submenu inclusion.

This allows the user to quickly select additional disk/tape/cdrom support from within the same menu.

---

drivers/Kconfig 2007-08-01 06:33:13.000000000 +0300 renamed from drivers/Kconfig 2007-05-02 17:25:30.000000000 +0300 +0 -2
@@ -22,8 +22,6 @@ source "drivers/ide/Kconfig"
 
 source "drivers/scsi/Kconfig"
 
-source "drivers/ata/Kconfig"
-
 source "drivers/cdrom/Kconfig"
 
 source "drivers/md/Kconfig"

drivers/scsi/Kconfig 2007-08-01 06:46:42.000000000 +0300 config RAID_ATTRS · line 14

Quoted 9 lines
drivers/scsi/Kconfig 2007-08-01 06:46:42.000000000 +0300 renamed from drivers/scsi/Kconfig 2007-07-09 06:38:37.000000000 +0300 +3 -1
@@ -7,6 +7,8 @@ config RAID_ATTRS
        ---help---
          Provides RAID
 
+source "drivers/ata/Kconfig"
+
 config SCSI
-       tristate "SCSI device support"
+       tristate "SCSI and Libata device support"
        depends on BLOCK

Actually, this should have read:

drivers/scsi/Kconfig +3 -1
@@ -1,4 +1,4 @@
-menu "SCSI device support"
+menu "SCSI and Libata (SATA/PATA/new IDE) device support"
 
 config RAID_ATTRS
        tristate "RAID Transport Class"
@@ -7,6 +7,8 @@ config RAID_ATTRS
        ---help---
          Provides RAID
 
+source "drivers/ata/Kconfig"
+
 config SCSI
        tristate "SCSI device support"
        depends on BLOCK

I would think that with this minimal change it would make it crystal clear, to anybody who can read, where to enable libata support, and at the same time not to forget/overlook sd/sr selection.

Thanks!

--
Al