Skip to contentSkip to conversation

radeonfb: add PCI Id for RS482/Radeon Xpress 200M

PATCH In review [email protected] 2 participants 3 messages Sep 4, 2007 – Sep 10, 2007 Framebuffer layer

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/4 radeonfb: add PCI Id for RS482/Radeon Xpress 200M

.. which can be found in Acer Aspire 5100.

Signed-off-by Andreas Herrmann <[email protected]>
---
 drivers/video/aty/ati_ids.h     |    1 +
 drivers/video/aty/radeon_base.c |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
drivers/video/aty/ati_ids.h +1 -0
index 685a754..648da1e 100644
@@ -211,3 +211,4 @@
 #define PCI_CHIP_RS350_7834             0x7834
 #define PCI_CHIP_RS350_7835             0x7835
 #define PCI_CHIP_RS480_5955             0x5955
+#define PCI_CHIP_RS482_5975             0x5975
drivers/video/aty/radeon_base.c +1 -0
index 47ca62f..90a3957 100644
@@ -102,6 +102,7 @@
 static struct pci_device_id radeonfb_pci_table[] = {
         /* Radeon Xpress 200m */
 	CHIP_DEF(PCI_CHIP_RS480_5955,   RS480,  CHIP_HAS_CRTC2 | CHIP_IS_IGP | CHIP_IS_MOBILITY),
+	CHIP_DEF(PCI_CHIP_RS482_5975,   RS480,  CHIP_HAS_CRTC2 | CHIP_IS_IGP | CHIP_IS_MOBILITY),
 	/* Mobility M6 */
 	CHIP_DEF(PCI_CHIP_RADEON_LY, 	RV100,	CHIP_HAS_CRTC2 | CHIP_IS_MOBILITY),
 	CHIP_DEF(PCI_CHIP_RADEON_LZ,	RV100,	CHIP_HAS_CRTC2 | CHIP_IS_MOBILITY),
Signature · 9 lines
1.5.3



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
Acked-by on v1 1/4
#1 lore raw
Quoted 3 lines · On Tue, 2007-09-04 at 12:58 +0200, [email protected] wrote:

.. which can be found in Acer Aspire 5100.

Signed-off-by Andreas Herrmann <[email protected]>
Acked-by Benjamin Herrenschmidt <[email protected]>
Quoted 19 lines
---
 drivers/video/aty/ati_ids.h     |    1 +
 drivers/video/aty/radeon_base.c |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
drivers/video/aty/ati_ids.h +1 -0
index 685a754..648da1e 100644
@@ -211,3 +211,4 @@
 #define PCI_CHIP_RS350_7834             0x7834
 #define PCI_CHIP_RS350_7835             0x7835
 #define PCI_CHIP_RS480_5955             0x5955
+#define PCI_CHIP_RS482_5975             0x5975
drivers/video/aty/radeon_base.c +0 -0
index 47ca62f..90a3957 100644

drivers/video/aty/radeon_base.c line 108

Quoted 7 lines
drivers/video/aty/radeon_base.c +1 -0
@@ -102,6 +102,7 @@
 static struct pci_device_id radeonfb_pci_table[] = {
         /* Radeon Xpress 200m */
 	CHIP_DEF(PCI_CHIP_RS480_5955,   RS480,  CHIP_HAS_CRTC2 | CHIP_IS_IGP | CHIP_IS_MOBILITY),
+	CHIP_DEF(PCI_CHIP_RS482_5975,   RS480,  CHIP_HAS_CRTC2 | CHIP_IS_IGP | CHIP_IS_MOBILITY),
 	/* Mobility M6 */
 	CHIP_DEF(PCI_CHIP_RADEON_LY, 	RV100,	CHIP_HAS_CRTC2 | CHIP_IS_MOBILITY),
 	CHIP_DEF(PCI_CHIP_RADEON_LZ,	RV100,	CHIP_HAS_CRTC2 | CHIP_IS_MOBILITY),

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/

author
#2 lore raw
Quoted 6 lines · Benjamin Herrenschmidt
Quoted 3 lines · On Tue, 2007-09-04 at 12:58 +0200, [email protected] wrote:

.. which can be found in Acer Aspire 5100.

Signed-off-by Andreas Herrmann <[email protected]>
Acked-by Benjamin Herrenschmidt <[email protected]>

Sorry, I have missed that 0x5975 was already defined for radeonfb. So this patch shouldn't be applied.

We have already:

        /*Mobility Xpress 200 */
        CHIP_DEF(PCI_CHIP_RS485_5975,   R300,   CHIP_HAS_CRTC2 | CHIP_IS_IGP | CHIP_IS_MOBILITY),

This was introduced with commit b5f2f4d1a6d7efde39cfb5e1d034981c69f2214c

But obviously this is not correct as the 0x5975 is an RS48x not R300. With the current git (w/o my patch) my display goes blank (or better it looks striped) and the Laptop hangs.

I'll do some further tests on my Laptop and probably come up with a new patch.

Regards,

Andreas

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/