2.6.23-rc4-mm1: kgdboe link errors
Hi,
randconfig [1] causes this link errors:
ERROR: "netpoll_cleanup" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_setup" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_parse_options" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_poll" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_send_udp" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_set_trap" [drivers/net/kgdboe.ko] undefined! make[2]: *** [__modpost] Error 1
make[1]: *** [modules] Error 2
make: *** [all] Error 2
[1] http://www.fi.muni.cz/~xslaby/sklad/1.config
regards,
Signature · 2 lines
http://www.fi.muni.cz/~xslaby/ Jiri Slaby faculty of informatics, masaryk university, brno, cz
PATCH 1/1 2.6.23-rc4-mm1: kgdboe link errors
Quoted 11 lines · On Wed, 12 Sep 2007 11:31:22 +0200 Jiri Slaby wrote:
randconfig [1] causes this link errors:
ERROR: "netpoll_cleanup" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_setup" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_parse_options" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_poll" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_send_udp" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_set_trap" [drivers/net/kgdboe.ko] undefined! make[2]: *** [__modpost] Error 1
make[1]: *** [modules] Error 2
make: *** [all] Error 2
Quoted 1 line
From: Randy Dunlap <[email protected]>
Fix kgdb build problems:
Building modules, stage 2.
ERROR: "netpoll_cleanup" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_setup" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_parse_options" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_poll" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_send_udp" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_set_trap" [drivers/net/kgdboe.ko] undefined! make[1]: *** [__modpost] Error 1
Add 'select' for net-poll/console related config symbols, but make KGDBOE 'depend on' NET. We don't want to 'select' CONFIG_NET, but if it is already enabled, the 'select's will enable the rest of the needed interfaces.
--- lib/Kconfig.kgdb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
lib/Kconfig.kgdb +3 -1
@@ -174,9 +174,11 @@ endchoice config KGDBOE tristate "KGDB: On ethernet" if !KGDBOE_NOMODULE - depends on m && KGDB + depends on m && KGDB && NET + select NETCONSOLE select NETPOLL select NETPOLL_TRAP + select NET_POLL_CONTROLLER help Uses the NETPOLL API to communicate with the host GDB via UDP. In order for this to work, the ethernet interface specified must
Quoted 42 lines · Randy Dunlap
Quoted 11 lines · On Wed, 12 Sep 2007 11:31:22 +0200 Jiri Slaby wrote:
randconfig [1] causes this link errors:
ERROR: "netpoll_cleanup" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_setup" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_parse_options" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_poll" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_send_udp" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_set_trap" [drivers/net/kgdboe.ko] undefined! make[2]: *** [__modpost] Error 1
make[1]: *** [modules] Error 2
make: *** [all] Error 2Quoted 1 line
From: Randy Dunlap <[email protected]>
Fix kgdb build problems:
Building modules, stage 2.
ERROR: "netpoll_cleanup" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_setup" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_parse_options" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_poll" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_send_udp" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_set_trap" [drivers/net/kgdboe.ko] undefined! make[1]: *** [__modpost] Error 1Add 'select' for net-poll/console related config symbols, but make KGDBOE 'depend on' NET. We don't want to 'select'
CONFIG_NET, but if it is already enabled, the 'select's will enable the rest of the needed interfaces.Signed-off-by Randy Dunlap <[email protected]>--- lib/Kconfig.kgdb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
lib/Kconfig.kgdb endchoice · line 178
Quoted 6 lines
lib/Kconfig.kgdb +2
-1@@ -174,9 +174,11 @@ endchoice config KGDBOE tristate "KGDB: On ethernet" if !KGDBOE_NOMODULE - depends on m && KGDB + depends on m && KGDB && NET + select NETCONSOLE
NETCONSOLE shouldn't be necessary. Otherwise this looks ok to my kconfig-addled brain.
Quoted 6 lines
lib/Kconfig.kgdb +1
-0select NETPOLL select NETPOLL_TRAP + select NET_POLL_CONTROLLER help Uses the NETPOLL API to communicate with the host GDB via UDP. In order for this to work, the ethernet interface specified must
Signature · 1 line
Mathematics is the supreme nostalgia of our time.
PATCH v2 1/1 2.6.23-rc4-mm1: kgdboe link errors
Quoted 2 lines · On Wed, 12 Sep 2007 13:15:12 -0500 Matt Mackall wrote:
NETCONSOLE shouldn't be necessary. Otherwise this looks ok to my kconfig-addled brain.
Correct. Patch corrected. Thanks.
---
From: Randy Dunlap <[email protected]>
Fix kgdb build problems:
Building modules, stage 2.
ERROR: "netpoll_cleanup" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_setup" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_parse_options" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_poll" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_send_udp" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_set_trap" [drivers/net/kgdboe.ko] undefined! make[1]: *** [__modpost] Error 1
Add 'select' for net-poll related config symbols, but make KGDBOE 'depend on' NET. We don't want to 'select' CONFIG_NET, but if it is already enabled, the 'select's will enable the rest of the needed interfaces.
--- lib/Kconfig.kgdb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
lib/Kconfig.kgdb +2 -1
@@ -174,9 +174,10 @@ endchoice config KGDBOE tristate "KGDB: On ethernet" if !KGDBOE_NOMODULE - depends on m && KGDB + depends on m && KGDB && NET select NETPOLL select NETPOLL_TRAP + select NET_POLL_CONTROLLER help Uses the NETPOLL API to communicate with the host GDB via UDP. In order for this to work, the ethernet interface specified must
Quoted 6 lines · Randy Dunlap
Quoted 2 lines · On Wed, 12 Sep 2007 13:15:12 -0500 Matt Mackall wrote:
NETCONSOLE shouldn't be necessary. Otherwise this looks ok to my kconfig-addled brain.
Correct. Patch corrected. Thanks.
Looks good to me, but I'll leave the actual ack to the KGDB guys.
Signature · 1 line
Mathematics is the supreme nostalgia of our time.
Randy,
This patch is fine, and I am committing it to the for_mm kgdb tree.
I am also adding the "depends on NET" to the KGDBOE_NOMODULE section, which would otherwise to a select on KGDBOE. We have to cover the case for KGDB as a module and not as a module.
Thanks,
Jason.
Quoted 57 lines · Randy Dunlap
Quoted 3 lines · On Wed, 12 Sep 2007 13:15:12 -0500 Matt Mackall wrote:
NETCONSOLE shouldn't be necessary. Otherwise this looks ok to my kconfig-addled brain.
Correct. Patch corrected. Thanks.
---
From: Randy Dunlap <[email protected]>Fix kgdb build problems:
Building modules, stage 2.
ERROR: "netpoll_cleanup" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_setup" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_parse_options" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_poll" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_send_udp" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_set_trap" [drivers/net/kgdboe.ko] undefined! make[1]: *** [__modpost] Error 1Add 'select' for net-poll related config symbols, but make KGDBOE 'depend on' NET. We don't want to 'select'
CONFIG_NET, but if it is already enabled, the 'select's will enable the rest of the needed interfaces.Signed-off-by Randy Dunlap <[email protected]>--- lib/Kconfig.kgdb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)lib/Kconfig.kgdb +2
-2@@ -174,9 +174,10 @@ endchoice config KGDBOE tristate "KGDB: On ethernet" if !KGDBOE_NOMODULE - depends on m && KGDB + depends on m && KGDB && NET select NETPOLL select NETPOLL_TRAP + select NET_POLL_CONTROLLER help Uses the NETPOLL API to communicate with the host GDB via UDP. In order for this to work, the ethernet interface specified must -------------------------------------------------------------------------This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Kgdb-bugreport mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport