Skip to contentSkip to conversation

Updated MPC8349ITX*_config to place config.tmp in correct location.

PATCH New Sparks 2 participants 2 messages Sep 13, 2007 Kbuild

lore
Share & tools
lore

Sparks

#0 lore raw

PATCH 1/1 Updated MPC8349ITX*_config to place config.tmp in correct location.

Hello All,

Please excuse any formatting issues in this email, as this is my first patch. I'm happy to resubmit, if necessary.

MPC834ITX*_config does not store config.tmp at the correct locatation, causing MPC8349ITXGP to have the wrong TEXT_BASE.

Regards,
Sam

---
 Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Makefile +0 -0
index 0371d46..d429126 100644
@@ -1797,10 +1797,10 @@ MPC8349ITXGP_config: unconfig
   @mkdir -p $(obj)board/mpc8349itx
   @echo "#define CONFIG_$(subst _LOWBOOT,,$(@:_config=))" >>

$(obj)include/config.h
@if [ "$(findstring GP,$@)" ] ; then \
- echo "TEXT_BASE = 0xFE000000" >$(obj)board/mpc8349itx/config.tmp ;
\
+ echo "TEXT_BASE = 0xFE000000"

Quoted 1 line

$(obj)board/freescale/mpc8349itx/config.tmp ; \

fi
@if [ "$(findstring LOWBOOT,$@)" ] ; then \
- echo "TEXT_BASE = 0xFE000000" >$(obj)board/mpc8349itx/config.tmp ;
\
+ echo "TEXT_BASE = 0xFE000000"

Quoted 1 line

$(obj)board/freescale/mpc8349itx/config.tmp ; \

fi
@$(MKCONFIG) -a -n $(@:_config=) MPC8349ITX ppc mpc83xx mpc8349itx
freescale

--
1.5.0.7

#1 lore raw

PATCH 1/1 Updated MPC8349ITX*_config to place config.tmp in correct location.

Quoted 3 lines · In message <[email protected]> you…

Please excuse any formatting issues in this email, as this is my first patch. I'm happy to resubmit, if necessary.

Signed-off-by line missing.
Quoted 3 lines
   @mkdir -p $(obj)board/mpc8349itx
   @echo "#define CONFIG_$(subst _LOWBOOT,,$(@:_config=))" >>

$(obj)include/config.h

^^^^^^^^^^^^^^^^^^^^^^^^^

Quoted 3 lines
   @if [ "$(findstring GP,$@)" ] ; then \

- echo "TEXT_BASE = 0xFE000000" >$(obj)board/mpc8349itx/config.tmp ;
\

^^^^^^^^^^^

Quoted 2 lines

+ echo "TEXT_BASE = 0xFE000000"

Quoted 1 line

$(obj)board/freescale/mpc8349itx/config.tmp ; \

^^^^^^^^^^^

...and corrupted because your mailer wrapped long lines,

Please fix your mailer settings, add the required information, and resubmit.

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"No one talks peace unless he's ready to back it up with war."
"He talks of peace if it is the only way to live."
	-- Colonel Green and Surak of Vulcan, "The Savage Curtain",
	   stardate 5906.5.