Removing of useless printk in drivers/acpi/video.c
PATCH 1/1 Removing of useless printk in drivers/acpi/video.c
Hi,
i am actually heavily using the ACPI video extension for my Thinkpad X61 Tablet. I have bound the input events triggered by the brightness up/down keys to a simple
echo <value> > /sys/class/backlight/acpi_video1/brightness
but everytime the event is triggered and acpi_video_device_lcd_set_level() is called i got a notificication in my kernel log like:
set_level status: 0set_level status: 0set_level status: 0set_level status: 0
...
I have attached a patch to remove this one printk() i really don't know why it is needed. :)
--Maik
drivers/acpi/video.c +0 -1
@@ -417,7 +417,6 @@ arg0.integer.value = level; status =acpi_evaluate_object (device->dev->handle,"_BCM" , &args,NULL ); -printk (KERN_DEBUG "set_level status: %x\n" , status);return status; }
Len Brown
reviewerhmmm, thought we had deleted this already.
anyway, its applied.
thanks,
-Len
Quoted 22 lines · Maik Broemme
Hi,
i am actually heavily using the ACPI video extension for my Thinkpad X61 Tablet. I have bound the input events triggered by the brightness up/down keys to a simple
echo <value> >
/sys/class/backlight/acpi_video1/brightnessbut everytime the event is triggered and
acpi_video_device_lcd_set_level()is called i got a notificication in my kernel log like:
set_levelstatus: 0set_levelstatus: 0set_levelstatus: 0set_levelstatus: 0
...I have attached a patch to remove this one
printk()i really don't know why it is needed. :)--Maik