Skip to contentSkip to conversation

add CFG_NAND_QUIET option

PATCH New Matthias Fuchs 2 participants 2 messages Sep 12, 2007 – Sep 15, 2007

lore
Share & tools
lore

Matthias Fuchs

author
#0 lore raw

PATCH 1/1 add CFG_NAND_QUIET option

Add CFG_NAND_QUIET option

This config option sets the default for the progress information output behavior that can also be configured through the 'quiet' environment variable.

The legacy NAND code does not print the current progress info on the console. So this option is for backward compatibility for units that are in the field and where setting the quiet variable is not an option. With CFG_NAND_QUIET set to '1' the console progress info is turned off. This can still be overwritten through the environment variable.

Signed-off-by Matthias Fuchs <[email protected]>

---
commit 3c84e878d4c38cda79646f540517cdcc9997ac07
tree 1c8e1fdb9f06710219bbe3abf758fb33a4d361d8
parent 72ce73aff517363e9fc9fe3ce8c1b21e47ab8fe0
author Matthias Fuchs <[email protected]> Wed, 12 Sep 2007 12:27:51 +0200 committer Matthias Fuchs <[email protected]> Wed, 12 Sep 2007 12:27:51 +0200

 common/cmd_nand.c        |    4 ++++
 include/configs/ASH405.h |    3 ++-
 include/configs/CMS700.h |    3 ++-
 include/configs/HH405.h  |    3 ++-
 include/configs/HUB405.h |    3 ++-
 include/configs/PLU405.h |    3 ++-
 include/configs/VOH405.h |    3 ++-
 7 files changed, 16 insertions(+), 6 deletions(-)
common/cmd_nand.c +4 -0
index 34b522b..1fdd7a6 100644
@@ -161,7 +161,11 @@ int do_nand(cmd_tbl_t * cmdtp, int flag,
 	ulong addr, off, size;
 	char *cmd, *s;
 	nand_info_t *nand;
+#ifdef CFG_NAND_QUIET
+	int quiet = CFG_NAND_QUIET;
+#else
 	int quiet = 0;
+#endif
 	const char *quiet_str = getenv("quiet");
 
 	/* at least two arguments please */
include/configs/ASH405.h +2 -1
index 0718c85..9adbba9 100644
@@ -158,7 +158,8 @@
 #define CFG_NAND_CLE            (0x80000000 >> 2)   /* our CLE is GPIO2 */
 #define CFG_NAND_ALE            (0x80000000 >> 3)   /* our ALE is GPIO3 */
 
-#define CFG_NAND_SKIP_BAD_DOT_I      1  /* ".i" read skips bad blocks   */
+#define CFG_NAND_SKIP_BAD_DOT_I 1       /* ".i" read skips bad blocks   */
+#define CFG_NAND_QUIET          1
 
 /*-----------------------------------------------------------------------
  * PCI stuff
include/configs/CMS700.h +2 -1
index 1fd2b53..21cd9c1 100644
@@ -165,7 +165,8 @@
 #define CFG_NAND_CLE            (0x80000000 >> 2)   /* our CLE is GPIO2 */
 #define CFG_NAND_ALE            (0x80000000 >> 3)   /* our ALE is GPIO3 */
 
-#define CFG_NAND_SKIP_BAD_DOT_I      1  /* ".i" read skips bad blocks   */
+#define CFG_NAND_SKIP_BAD_DOT_I 1       /* ".i" read skips bad blocks   */
+#define CFG_NAND_QUIET          1
 
 /*-----------------------------------------------------------------------
  * PCI stuff
include/configs/HH405.h +2 -1
index ea8e61a..8967b3f 100644
@@ -217,7 +217,8 @@
 #define CFG_NAND_CLE            (0x80000000 >> 2)   /* our CLE is GPIO2 */
 #define CFG_NAND_ALE            (0x80000000 >> 3)   /* our ALE is GPIO3 */
 
-#define CFG_NAND_SKIP_BAD_DOT_I      1  /* ".i" read skips bad blocks   */
+#define CFG_NAND_SKIP_BAD_DOT_I 1       /* ".i" read skips bad blocks   */
+#define CFG_NAND_QUIET          1
 
 /*-----------------------------------------------------------------------
  * PCI stuff
include/configs/HUB405.h +2 -1
index ed669c5..1ff7108 100644
@@ -157,7 +157,8 @@
 #define CFG_NAND_CLE            (0x80000000 >> 2)   /* our CLE is GPIO2 */
 #define CFG_NAND_ALE            (0x80000000 >> 3)   /* our ALE is GPIO3 */
 
-#define CFG_NAND_SKIP_BAD_DOT_I      1  /* ".i" read skips bad blocks   */
+#define CFG_NAND_SKIP_BAD_DOT_I 1       /* ".i" read skips bad blocks   */
+#define CFG_NAND_QUIET          1
 
 /*-----------------------------------------------------------------------
  * PCI stuff
include/configs/PLU405.h +2 -1
index 4acbcd5..652210c 100644
@@ -177,7 +177,8 @@
 #define CFG_NAND_CLE            (0x80000000 >> 2)   /* our CLE is GPIO2 */
 #define CFG_NAND_ALE            (0x80000000 >> 3)   /* our ALE is GPIO3 */
 
-#define CFG_NAND_SKIP_BAD_DOT_I      1  /* ".i" read skips bad blocks   */
+#define CFG_NAND_SKIP_BAD_DOT_I 1       /* ".i" read skips bad blocks   */
+#define CFG_NAND_QUIET          1
 
 /*-----------------------------------------------------------------------
  * PCI stuff
include/configs/VOH405.h +2 -1
index 3880ec7..14848ab 100644
@@ -163,7 +163,8 @@
 #define CFG_NAND_CLE            (0x80000000 >> 2)   /* our CLE is GPIO2 */
 #define CFG_NAND_ALE            (0x80000000 >> 3)   /* our ALE is GPIO3 */
 
-#define CFG_NAND_SKIP_BAD_DOT_I      1  /* ".i" read skips bad blocks   */
+#define CFG_NAND_SKIP_BAD_DOT_I 1       /* ".i" read skips bad blocks   */
+#define CFG_NAND_QUIET          1
 
 /*-----------------------------------------------------------------------
  * PCI stuff
Applied
#1 lore raw

PATCH 1/1 add CFG_NAND_QUIET option

Quoted 6 lines · In message <[email protected]> you wrote:

Add CFG_NAND_QUIET option

This config option sets the default for the progress information output behavior that can also be configured through the 'quiet' environment variable.

Quoted 8 lines

The legacy NAND code does not print the current progress info on the console. So this option is for backward compatibility for units that are in the field and where setting the quiet variable is not an option. With CFG_NAND_QUIET set to '1' the console progress info is turned off. This can still be overwritten through the environment variable.

Signed-off-by Matthias Fuchs <[email protected]>

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Einstein argued that there must be simplified explanations of nature,
because God is not capricious or arbitrary. No  such  faith  comforts
the software engineer.                             - Fred Brooks, Jr.