Skip to contentSkip to conversation

kbuild update

DISCUSSION Sam Ravnborg 3 participants 6 messages Sep 16, 2007

lore
Share & tools
lore
#0 lore raw

A summary of what is planned to be submitted in next merge window for kbuild. The shortlog below have additional details but the headlines are:

o Make the kernel buildable on a cygwin box (but not without a few glitches)
o detect unterminated device id list
o add export_report as a valid top-level make target
o add script to find unused kconfig symbols (try it!)
o allow a user to specify additional flags on the commandline with CFLAGS, AFLAGS or CPPFLAGS. The flags will be appended to the kernel defiend flags

The CFLAGS change will conflict with Andi's x86 patches and I fix it before pushing if Andi's patches are pushed first. Otherwise no conflicts.

The vmlinux.lds changes that I have sent to a number of arch maintainers lately are not included.
I expect them to be applied by the respective arch maintainers.

The --gc-section cleanup from Denys Vlasenko will be included in kbuild after the merge window so we can try it out in -mm before hitting mainline.

Jan Beulich kconfig patch will most likely be included. Need to test it first.

Marej menuconfig improvement may also be included. Last patch looked good but have not made up my mind if it really help people.

Patched referred below are available at git.kernel.org at kbuild.git in an hour or so.

Sam

Adrian Bunk (2):
kbuild: fix export_report.pl
kbuild: call export_report from the Makefile

Jesper Juhl (3):
kbuild: improve scripts/gcc-version.sh output a bit when called without args
kbuild: ver_linux fix glibc version print
kbuild: scripts/ver_linux : correct printing of binutils version

Kees Cook (1):
kbuild: make modpost detect unterminated device id lists

Mike Frysinger (1):
kbuild: clean Modules.symvers in external module dirs

Paolo 'Blaisorblade' Giarrusso (1):
kbuild: script to check for undefined Kconfig symbols

Petr Stetiar (1):
kbuild: fix segfault in modpost

Ram Pai (1):
kbuild: fix perl usage in export_report.pl

Randy Dunlap (1):
docproc: style & typo cleanups

Sam Ravnborg (10):
kbuild: Use Elfnn_Half as replacement for Elfnn_Section
kbuild: check if we can link gettext not just compile
kbuild: fix genksyms Makefile
kbuild: __extension__ support in genksyms (fix unknown CRC warning)
kbuild: apply genksyms changes
kbuild: enable 'make CFLAGS=...' to add additional options to CC
kbuild: enable 'make AFLAGS=...' to add additional options to AS
ia64: fix sn to add include files using EXTRA_CFLAGS
kbuild: enable 'make CPPFLAGS=...' to add additional options to CPP
kbuild: fix directory traversal bug

Shlomi Fish (1):
kconfig: qconf ("make xconfig") Search Dialog Enhancement

#1 lore raw
Quoted 2 lines · Sam Ravnborg

A summary of what is planned to be submitted in next merge window for kbuild. The shortlog below have additional details but the headlines are:

...

Quoted 1 line

o add script to find unused kconfig symbols (try it!)

based on my experiences with this, unless you filter carefully, you're going to end up with a *whack* of false positives given the number of developers who elect to name their local macros starting with a prefix of "CONFIG_". good luck dealing with *that*. :-)

rday

Signature · 7 lines
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================
#2 lore raw
Quoted 11 lines · Robert P. J. Day
Quoted 2 lines · Sam Ravnborg

A summary of what is planned to be submitted in next merge window for kbuild. The shortlog below have additional details but the headlines are:

...

Quoted 1 line

o add script to find unused kconfig symbols (try it!)

based on my experiences with this, unless you filter carefully, you're going to end up with a *whack* of false positives given the number of developers who elect to name their local macros starting with a prefix of "CONFIG_". good luck dealing with *that*. :-)

This is useful for specific people but not for kernel janitorial fodder. As you already experience the amount of false positive are too high.

But for a developer of a module it is no deal to ignore the false positives.

It is for godd reasons not integrated in the build process.

Sam

#3 lore raw
Quoted 13 lines · Sam Ravnborg
Quoted 11 lines · Robert P. J. Day
Quoted 2 lines · Sam Ravnborg

A summary of what is planned to be submitted in next merge window for kbuild. The shortlog below have additional details but the headlines are:

...

Quoted 1 line

o add script to find unused kconfig symbols (try it!)

based on my experiences with this, unless you filter carefully, you're going to end up with a *whack* of false positives given the number of developers who elect to name their local macros starting with a prefix of "CONFIG_". good luck dealing with *that*. :-)

Quoted 8 lines

This is useful for specific people but not for kernel janitorial fodder. As you already experience the amount of false positive are too high.

But for a developer of a module it is no deal to ignore the false positives.

It is for godd reasons not integrated in the build process.

right, i agree completely. if it were absolutely reliable in generating *only* actual unused symbols, then that *might* (i stress, *might*) be a viable argument for making it part of the Kbuild system.

but, really, if you can whip off a script that does most of the job in a few minutes, there's really no motivation to then spend hours trying to nail those last few harmless bits of irrelevant output.

rday

Signature · 7 lines
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================
#4 lore raw
In reply to Robert P. J. Day
Quoted 11 lines · On Sun, 16 Sep 2007 08:58:03 -0400 (EDT) "Robert P. J. Day"…
Quoted 2 lines · Sam Ravnborg

A summary of what is planned to be submitted in next merge window for kbuild. The shortlog below have additional details but the headlines are:

...

Quoted 1 line

o add script to find unused kconfig symbols (try it!)

based on my experiences with this, unless you filter carefully, you're going to end up with a *whack* of false positives given the number of developers who elect to name their local macros starting with a prefix of "CONFIG_". good luck dealing with *that*. :-)

box:/usr/src/linux-2.6.23-rc6> grep -r '^[ ]*#[ ]*define[ ]*CONFIG_' . | wc -l
415

bah. They're all bugs - The CONFIG_foo namespace is (should be) reserved in kernel coding.

#5 lore raw
Quoted 14 lines · Andrew Morton
Quoted 11 lines · On Sun, 16 Sep 2007 08:58:03 -0400 (EDT) "Robert P. J. Day"…
Quoted 2 lines · Sam Ravnborg

A summary of what is planned to be submitted in next merge window for kbuild. The shortlog below have additional details but the headlines are:

...

Quoted 1 line

o add script to find unused kconfig symbols (try it!)

based on my experiences with this, unless you filter carefully, you're going to end up with a *whack* of false positives given the number of developers who elect to name their local macros starting with a prefix of "CONFIG_". good luck dealing with *that*. :-)

Quoted 5 lines

box:/usr/src/linux-2.6.23-rc6> grep -r '^[ ]*#[ ]*define[ ]*CONFIG_' . | wc -l
415

bah. They're all bugs - The CONFIG_foo namespace is (should be) reserved in kernel coding.

I get (after a bit more filtering 349 hits of which 182 are outside drivers/

Of the 182 the 25 of them are in arch specific code.

I se no good reasons to address this unless we touch code in that area anyway. But avoiding new entries are good.

Sam