Skip to contentSkip to conversation

acpi_video: kernel build error if !INPUT

PATCH Applied Andreas Herrmann 2 participants 2 messages Sep 17, 2007 – Sep 18, 2007 ACPI

lore
Share & tools
lore

Andreas Herrmann

author
#0 lore raw

PATCH 1/1 acpi_video: kernel build error if !INPUT

Commit e9dab1960ac9746fa34eff726b81635147615a79 exports ACPI video hotkey events via input layer. But this breaks kernel build if ACPI_VIDEO && !INPUT:

LD .tmp_vmlinux1
drivers/built-in.o: In function `acpi_video_bus_remove':
drivers/acpi/video.c:2007: undefined reference to `input_unregister_device'

    ...

Add dependency to INPUT for ACPI_VIDEO to prevent this error.

Signed-off-by Andreas Herrmann <[email protected]>
---
 drivers/acpi/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/acpi/Kconfig +1 -0
index 4875f01..9685b75 100644
@@ -117,6 +117,7 @@ config ACPI_BUTTON
 config ACPI_VIDEO
 	tristate "Video"
 	depends on X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL
+	depends on INPUT
 	help
 	  This driver implement the ACPI Extensions For Display Adapters
 	  for integrated graphics devices on motherboard, as specified in
Signature · 1 line
1.5.3
reviewer Applied
#1 lore raw

Applied.

thanks,
-Len

Quoted 28 lines · Andreas Herrmann

Commit e9dab1960ac9746fa34eff726b81635147615a79 exports ACPI video hotkey events via input layer. But this breaks kernel build if ACPI_VIDEO && !INPUT:

LD .tmp_vmlinux1
drivers/built-in.o: In function `acpi_video_bus_remove':
drivers/acpi/video.c:2007: undefined reference to `input_unregister_device'

    ...

Add dependency to INPUT for ACPI_VIDEO to prevent this error.

Signed-off-by Andreas Herrmann <[email protected]>
---
 drivers/acpi/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/acpi/Kconfig +1 -0
index 4875f01..9685b75 100644
@@ -117,6 +117,7 @@ config ACPI_BUTTON
 config ACPI_VIDEO
 	tristate "Video"
 	depends on X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL
+	depends on INPUT
 	help
 	  This driver implement the ACPI Extensions For Display Adapters
 	  for integrated graphics devices on motherboard, as specified in