Skip to contentSkip to conversation

Clean up IOC reset code to obey coding style

PATCH New Darrick J. Wong 1 participant 1 message Sep 20, 2007

Subsystems (2)
SCSI LSI Logic MPT fusion drivers (FC/SAS/SPI)
lore
Share & tools
lore

Darrick J. Wong

author
#0 lore raw

PATCH 1/1 Clean up IOC reset code to obey coding style

Randy Dunlap scolded me for introducing poorly styled code. Since it was a copy-and-paste block from mpt_suspend(), fix both.

Signed-off-by Darrick J. Wong <[email protected]>

---

 drivers/message/fusion/mptbase.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)
drivers/message/fusion/mptbase.c +2 -4
index 40b8b41..2952a54 100644
@@ -1721,10 +1721,9 @@ mpt_suspend(struct pci_dev *pdev, pm_message_t state)
 	pci_save_state(pdev);
 
 	/* put ioc into READY_STATE */
-	if(SendIocReset(ioc, MPI_FUNCTION_IOC_MESSAGE_UNIT_RESET, CAN_SLEEP)) {
+	if (SendIocReset(ioc, MPI_FUNCTION_IOC_MESSAGE_UNIT_RESET, CAN_SLEEP))
 		printk(MYIOC_s_ERR_FMT
 		"pci-suspend:  IOC msg unit reset failed!\n", ioc->name);
-	}
 
 	/* disable interrupts */
 	CHIPREG_WRITE32(&ioc->chip->IntMask, 0xFFFFFFFF);

@@ -1773,10 +1772,9 @@ mpt_resume(struct pci_dev *pdev)
 		CHIPREG_READ32(&ioc->chip->Doorbell));
 
 	/* put ioc into READY_STATE */
-	if(SendIocReset(ioc, MPI_FUNCTION_IOC_MESSAGE_UNIT_RESET, CAN_SLEEP)) {
+	if (SendIocReset(ioc, MPI_FUNCTION_IOC_MESSAGE_UNIT_RESET, CAN_SLEEP))
 		printk(MYIOC_s_ERR_FMT
 		"pci-resume:  IOC msg unit reset failed!\n", ioc->name);
-	}
 
 	/* bring ioc to operational state */
 	if ((recovery_state = mpt_do_ioc_recovery(ioc,