E1000: Do not allow requeue of freed skb

PATCH New Krishna Kumar 1 participant 1 message Sep 21, 2007

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Krishna Kumar

author

2007-09-21 04:58 UTC #0 lore raw

PATCH 1/1 E1000: Do not allow requeue of freed skb

Returning BUSY will make qdisc_restart enqueue the skb which was already freed. The bad skb was correctly freed and we should return NETDEV_TX_OK.

Signed-off-by Krishna Kumar <[email protected]>

---

drivers/net/e1000e/netdev.c +1 -1

diff -ruNp a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
@@ -3531,7 +3531,7 @@ static int e1000_xmit_frame(struct sk_bu
 		/* handle pci_map_single() error in e1000_tx_map */
 		dev_kfree_skb_any(skb);
 		spin_unlock_irqrestore(&adapter->tx_queue_lock, irq_flags);
-		return NETDEV_TX_BUSY;
+		return NETDEV_TX_OK;
 	}
 
 	e1000_tx_queue(adapter, tx_flags, count);