Skip to contentSkip to conversation

2.6.23-rc8-mm1, -rc7-mm1 kill audio on HP nx6325

DISCUSSION Andrew Morton 3 participants 3 messages Sep 25, 2007 – Sep 26, 2007 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 10 lines · On Tue, 25 Sep 2007 13:53:51 +0200 "Rafael J. Wysocki" <[email protected]> wrote:

Hi,

This patch from Andi:

x86_64-mm-cpa-einval.patch

makes the hda_intel audio driver stop working on my HP nx6325.

The following line appears in dmesg (from 2.6.23-rc7-mm1:

Quoted 8 lines

ALSA /home/rafael/src/mm/linux-2.6.23-rc7-mm1/sound/pci/hda/hda_intel.c:1755: hd
a-intel: ioremap error

and the driver doesn't work afterwards.

Still, I'm not sure if the patch above is wrong or rather it exposes a problem in the driver.

Mysterious.

ioremap_nocache() does __ioremap(..., _PAGE_PCD);, then __ioremap() does ioremap_page_range(..., _PAGE_PCD | other_stuff) That's one.

__ioremap() then does ioremap_change_attr(..., _PAGE_PCD);. That's two.

So I _think_ we're setting _PAGE_PCD twice on those pte's? Unclear. The implementation is rather different from i386, too.

I dunno why __change_page_attr() failed though. Perhaps this, in change_page_attr_addr():

		if (!kernel_map || pte_present(pfn_pte(0, prot))) {

should be &&

Andi's taking a bit of time off, so we may need to park this until he resurfaces.

#2 lore raw
Quoted 32 lines
Quoted 1 line
Quoted 1 line

Andrew Morton <[email protected]> 25.09.07 18:08 >>>

Quoted 10 lines · On Tue, 25 Sep 2007 13:53:51 +0200 "Rafael J. Wysocki" <[email protected]> wrote:

Hi,

This patch from Andi:

x86_64-mm-cpa-einval.patch

makes the hda_intel audio driver stop working on my HP nx6325.

The following line appears in dmesg (from 2.6.23-rc7-mm1:

Quoted 8 lines

ALSA /home/rafael/src/mm/linux-2.6.23-rc7-mm1/sound/pci/hda/hda_intel.c:1755: hd
a-intel: ioremap error

and the driver doesn't work afterwards.

Still, I'm not sure if the patch above is wrong or rather it exposes a problem in the driver.

Mysterious.

ioremap_nocache() does __ioremap(..., _PAGE_PCD);, then __ioremap() does ioremap_page_range(..., _PAGE_PCD | other_stuff) That's one.

__ioremap() then does ioremap_change_attr(..., _PAGE_PCD);. That's two.

So I _think_ we're setting _PAGE_PCD twice on those pte's? Unclear. The implementation is rather different from i386, too.

Quoted 6 lines

I dunno why __change_page_attr() failed though. Perhaps this, in change_page_attr_addr():

		if (!kernel_map || pte_present(pfn_pte(0, prot))) {

should be &&

Definitely not, and this code has been that way for a while.

I rather suspect this change

- if (!kpte) return 0;
+ if (!kpte)
+ return -EINVAL;

to be the reason for the failure (and I had already sent a comment to this respect to Andi upon his review request).

Jan

#3 lore raw
Quoted 23 lines · Jan Beulich
Quoted 8 lines

ioremap_nocache() does __ioremap(..., _PAGE_PCD);, then __ioremap() does ioremap_page_range(..., _PAGE_PCD | other_stuff) That's one.

__ioremap() then does ioremap_change_attr(..., _PAGE_PCD);. That's two.

So I _think_ we're setting _PAGE_PCD twice on those pte's? Unclear. The implementation is rather different from i386, too.

Quoted 6 lines

I dunno why __change_page_attr() failed though. Perhaps this, in change_page_attr_addr():

		if (!kernel_map || pte_present(pfn_pte(0, prot))) {

should be &&

Definitely not, and this code has been that way for a while.

I rather suspect this change

(quoted diff) +2 -1
-	if (!kpte) return 0;
+	if (!kpte)
+		return -EINVAL;
Quoted 2 lines

to be the reason for the failure (and I had already sent a comment to this respect to Andi upon his review request).

This change exposes the problem. The question is why we do not have a page table entry for the address, which was mapped right before that.

tglx