Skip to contentSkip to conversation

xen-tools dependency check fix

PATCH In review Christoph Egger 2 participants 4 messages Sep 25, 2007

lore
Share & tools
lore

Christoph Egger

author
#0 lore raw

PATCH 1/1 xen-tools dependency check fix

Hi!

zlib and crypto libs are part of the base system in *BSD. So no need to check for them on *BSD.

Signed-off-by Christoph Egger <[email protected]>
Signature · 12 lines
AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy
tools/check/check_crypto_lib +8 -0
diff -r ad339d88639d tools/check/check_crypto_lib
@@ -2,6 +2,14 @@
 # CHECK-BUILD CHECK-INSTALL
 
 RC=0
+
+case $(uname -s) in
+FreeBSD|NetBSD|OpenBSD)
+	exit 0
+	;;
+*)
+	;;
+esac
 
 PATH=/sbin:$PATH
 set -e
tools/check/check_zlib_lib +8 -0
diff -r ad339d88639d tools/check/check_zlib_lib
@@ -2,6 +2,14 @@
 # CHECK-BUILD CHECK-INSTALL
 
 RC=0
+
+case $(uname -s) in
+FreeBSD|NetBSD|OpenBSD)
+	exit 0
+	;;
+*)
+	;;
+esac
 
 PATH=/sbin:$PATH

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#1 lore raw
Quoted 2 lines · Christoph Egger

zlib and crypto libs are part of the base system in *BSD. So no need to check for them on *BSD.

The checks should succeed though, right? So why not just leave the scripts as they are?

-- Keir

author
#2 lore raw
Quoted 6 lines · On Tuesday 25 September 2007 10:57:19 Keir Fraser wrote:
Quoted 2 lines · Christoph Egger

zlib and crypto libs are part of the base system in *BSD. So no need to check for them on *BSD.

The checks should succeed though, right? So why not just leave the scripts as they are?

Basically yes, but the non-portable command is ldconfig. Different options, different outputs, even between the different BSDs.
So the patch goes the easiest way to deal with that.

Signature · 12 lines
AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy
#3 lore raw
Quoted 6 lines · Christoph Egger
Quoted 2 lines

The checks should succeed though, right? So why not just leave the scripts as they are?

Basically yes, but the non-portable command is ldconfig. Different options, different outputs, even between the different BSDs.
So the patch goes the easiest way to deal with that.

Ah, ok.

K.