usb_serial: Stop passing NULL to functions that expect data
PATCH 1/1 usb_serial: Stop passing NULL to functions that expect data
Earlier patches have removed the checking for old v new differences from the USB drivers so we can now pass in a valid blank old termios so that we don't to fill the drivers with magic hacks for console support
drivers/serial/serial_core.c +2 -1
@@ -1885,6 +1885,7 @@ int baud, int parity, int bits, int flow) { struct ktermios termios; +static struct ktermios dummy;int i;/*
@@ -1930,7 +1931,7 @@*/ port->mctrl |=TIOCM_DTR ; - port->ops->set_termios (port, &termios,NULL ); + port->ops->set_termios (port, &termios, &dummy); co->cflag = termios.c_cflag;return 0 ;
Quoted 3 lines · On Wed, 26 Sep 2007 23:08:40 +0100 Alan Cox <[email protected]> wrote:
Earlier patches have removed the checking for old v new differences from the USB drivers so we can now pass in a valid blank old termios so that we don't to fill the drivers with magic hacks for console support
Are all the prerequisites for these patches in mainline, or are there dependencies on -mm stuff here?
Quoted 9 lines · On Wed, 26 Sep 2007 15:52:48 -0700 Andrew Morton <[email protected]>…
Quoted 3 lines · On Wed, 26 Sep 2007 23:08:40 +0100 Alan Cox <[email protected]> wrote:
Earlier patches have removed the checking for old v new differences from the USB drivers so we can now pass in a valid blank old termios so that we don't to fill the drivers with magic hacks for console support
Are all the prerequisites for these patches in mainline, or are there dependencies on -mm stuff here?
Sorry pre-req for the USB serial ones is the tty patch I sent you last chunk that added tty_encode_baud_rate
I'd prefer them to sit in -mm a bit. I'm pretty sure most of them are 100% solid but I also want to see if we get any app breakages caused by correcting our behaviour
Alan