Skip to contentSkip to conversation

proper comment for loopback initialization order

PATCH Applied Denis V. Lunev 2 participants 2 messages Sep 27, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 proper comment for loopback initialization order

Loopback device is special. It should be initialized at the very beginning. Initialization order has been changed by
Eric W. Biederman <[email protected]> and this change is non-obvious and important enough to add proper comment.

drivers/net/loopback.c renamed from drivers/net/loopback.c.loopcomment +2 -0
@@ -293,4 +293,6 @@ static int __init loopback_init(void)
 	return register_pernet_device(&loopback_net_ops);
 }
 
+/* Loopback is special. It should be initialized before any other network
+   device and network subsystem */
 fs_initcall(loopback_init);
maintainer Applied
#1 lore raw

From: "Denis V. Lunev" <[email protected]>
Date: Thu, 27 Sep 2007 16:25:27 +0400

Quoted 9 lines

Subject: [PATCH] proper comment for loopback initialization order
From: "Denis V. Lunev" <[email protected]>
To: [email protected]
Cc: [email protected], [email protected], [email protected],
[email protected]
Date: Thu, 27 Sep 2007 16:25:27 +0400
Sender: <[email protected]>
User-Agent: Mutt/1.5.16 (2007-06-09)

Quoted 6 lines

Loopback device is special. It should be initialized at the very beginning. Initialization order has been changed by
Eric W. Biederman <[email protected]> and this change is non-obvious and important enough to add proper comment.

Applied, but I had to fix the coding style of your comment, please do it like this in the future:

/* Loopback is special. It should be initialized before any other network
* device and network subsystem.
*/

Thanks.