Skip to contentSkip to conversation

clockevents: fix bogus next_event reset for oneshot broadcast devices]

PATCH In review Ralf Baechle 1 participant 2 messages Sep 27, 2007 – Sep 28, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clockevents: fix bogus next_event reset for oneshot broadcast devices]

----- Forwarded message from Thomas Gleixner <[email protected]> -----

From: Thomas Gleixner <[email protected]>
Date: Fri, 28 Sep 2007 00:17:04 +0200
To: LKML <[email protected]>
Cc: Andrew Morton <[email protected]>, Ralf Baechle <[email protected]>
Subject: [PATCH] clockevents: fix bogus next_event reset for oneshot
broadcast devices
Content-Type: text/plain

In periodic broadcast mode the next_event member of the broadcast device structure is set to KTIME_MAX in the interrupt handler. This is wrong, as we calculate the next periodic interrupt with this variable.

Remove it.

Noticed by Ralf. MIPS is the first user of this mode, it does not affect existing users.

---

kernel/time/tick-broadcast.c +0 -2
index 0962e05..acf15b4 100644
@@ -176,8 +176,6 @@ static void tick_do_periodic_broadcast(void)
  */
 static void tick_handle_periodic_broadcast(struct clock_event_device *dev)
 {
-	dev->next_event.tv64 = KTIME_MAX;
-
 	tick_do_periodic_broadcast();
 
 	/*

----- End forwarded message -----

Ralf

#1 lore raw
Quoted 8 lines · Ralf Baechle

From: Thomas Gleixner <[email protected]>
Date: Fri, 28 Sep 2007 00:17:04 +0200
To: LKML <[email protected]>
Cc: Andrew Morton <[email protected]>, Ralf Baechle <[email protected]>
Subject: [PATCH] clockevents: fix bogus next_event reset for oneshot
broadcast devices
Content-Type: text/plain

Quoted 8 lines

In periodic broadcast mode the next_event member of the broadcast device structure is set to KTIME_MAX in the interrupt handler. This is wrong, as we calculate the next periodic interrupt with this variable.

Remove it.

Noticed by Ralf. MIPS is the first user of this mode, it does not affect existing users.

Which is a different from what I was using, so that throws somewhat of a wrench into some of the MIPS dyntick mechanics. But it doesn't change the fact that this fix is correct.

Ralf