Skip to contentSkip to conversation

rfkill: Move rfkill_switch_all out of global header

PATCH Applied Ivo van Doorn 2 participants 2 messages Sep 27, 2007

Subsystems (3)
Networking Network drivers Rfkill
lore
Share & tools
lore

Ivo van Doorn

author
#0 lore raw

PATCH 1/1 rfkill: Move rfkill_switch_all out of global header

rfkill_switch_all shouldn't be called by drivers directly, instead they should send a signal over the input device.

To prevent confusion for driver developers, move the function into a rfkill private header.

Signed-off-by Ivo van Doorn <[email protected]>

---

include/linux/rfkill.h +1 -3
index f9a50da..67096b5 100644
@@ -2,7 +2,7 @@
 #define __RFKILL_H
 
 /*
- * Copyright (C) 2006 Ivo van Doorn
+ * Copyright (C) 2006 - 2007 Ivo van Doorn
  * Copyright (C) 2007 Dmitry Torokhov
  *
  * This program is free software; you can redistribute it and/or modify

@@ -84,6 +84,4 @@ void rfkill_free(struct rfkill *rfkill);
 int rfkill_register(struct rfkill *rfkill);
 void rfkill_unregister(struct rfkill *rfkill);
 
-void rfkill_switch_all(enum rfkill_type type, enum rfkill_state state);
-
 #endif /* RFKILL_H */
net/rfkill/rfkill-input.c +2 -0
index 8e4516a..eaabf08 100644
@@ -17,6 +17,8 @@
 #include <linux/init.h>
 #include <linux/rfkill.h>
 
+#include "rfkill-input.h"
+
 MODULE_AUTHOR("Dmitry Torokhov <[email protected]>");
 MODULE_DESCRIPTION("Input layer to RF switch connector");
 MODULE_LICENSE("GPL");
net/rfkill/rfkill-input.h new file +16 -0
new file mode 100644
index 0000000..4dae500
@@ -0,0 +1,16 @@
+/*
+ * Copyright (C) 2007 Ivo van Doorn
+ */
+
+/*
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 as published
+ * by the Free Software Foundation.
+ */
+
+#ifndef __RFKILL_INPUT_H
+#define __RFKILL_INPUT_H
+
+void rfkill_switch_all(enum rfkill_type type, enum rfkill_state state);
+
+#endif /* __RFKILL_INPUT_H */
net/rfkill/rfkill.c +1 -1
index 03ed7fd..00ee534 100644
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2006 Ivo van Doorn
+ * Copyright (C) 2006 - 2007 Ivo van Doorn
  * Copyright (C) 2007 Dmitry Torokhov
  *
  * This program is free software; you can redistribute it and/or modify
maintainer Applied
#1 lore raw

From: Ivo van Doorn <[email protected]>
Date: Fri, 28 Sep 2007 00:07:41 +0200

Quoted 7 lines

rfkill_switch_all shouldn't be called by drivers directly, instead they should send a signal over the input device.

To prevent confusion for driver developers, move the function into a rfkill private header.

Signed-off-by Ivo van Doorn <[email protected]>

Applied to net-2.6.24, thanks.