Skip to contentSkip to conversation

Clean up redundant PHY write line for ULi526x Ethernet driver

PATCH Applied Zang Roy-r61911 3 participants 4 messages Sep 24, 2007 – Sep 29, 2007

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Zang Roy-r61911

author
#0 lore raw

PATCH 1/1 Clean up redundant PHY write line for ULi526x Ethernet driver

From: Roy Zang <[email protected]>

Clean up redundant PHY write line for ULi526x Ethernet Driver.

Signed-off-by Roy Zang <[email protected]>
---
 drivers/net/tulip/uli526x.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/net/tulip/uli526x.c +0 -1
index ca2548e..53a8e65 100644
@@ -1512,7 +1512,6 @@ static void uli526x_process_mode(struct uli526x_board_info *db)
 			case ULI526X_100MFD: phy_reg = 0x2100; break;
 			}
 			phy_write(db->ioaddr, db->phy_addr, 0, phy_reg, db->chip_id);
-       			phy_write(db->ioaddr, db->phy_addr, 0, phy_reg, db->chip_id);
 		}
 	}
 }
Signature · 1 line
1.5.2
#1 lore raw
Quoted 15 lines · Zang Roy-r61911 wrote:

From: Roy Zang <[email protected]>

Clean up redundant PHY write line for ULi526x Ethernet Driver.

Signed-off-by Roy Zang <[email protected]>
---
 drivers/net/tulip/uli526x.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/net/tulip/uli526x.c +0 -0
index ca2548e..53a8e65 100644

drivers/net/tulip/uli526x.c static void uli526x_process_mode(struct uli526x_board_info *db) · line 1515

Quoted 4 lines
drivers/net/tulip/uli526x.c +0 -1
@@ -1512,7 +1512,6 @@ static void uli526x_process_mode(struct uli526x_board_info *db)
 			case ULI526X_100MFD: phy_reg = 0x2100; break;
 			}
 			phy_write(db->ioaddr, db->phy_addr, 0, phy_reg, db->chip_id);
-       			phy_write(db->ioaddr, db->phy_addr, 0, phy_reg, db->chip_id);

Kyle and Grant, I'll queue this up, unless ya'll object...

Jeff

#2 lore raw
Quoted 12 lines · Jeff Garzik
Quoted 11 lines · Zang Roy-r61911 wrote:

From: Roy Zang <[email protected]> Clean up redundant PHY write line for ULi526x Ethernet Driver.

Signed-off-by Roy Zang <[email protected]>
---
 drivers/net/tulip/uli526x.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/net/tulip/uli526x.c +0 -0
index ca2548e..53a8e65 100644
Quoted 8 lines

drivers/net/tulip/uli526x.c static void uli526x_process_mode(struct · line 1516

Quoted 6 lines
drivers/net/tulip/uli526x.c +0 -1
@@ -1512,7 +1512,6 @@ static void uli526x_process_mode(struct 
 uli526x_board_info *db)
 			case ULI526X_100MFD: phy_reg = 0x2100; break;
 			}
 			phy_write(db->ioaddr, db->phy_addr, 0, phy_reg, db->chip_id);
-       			phy_write(db->ioaddr, db->phy_addr, 0, phy_reg, db->chip_id);

Kyle and Grant, I'll queue this up, unless ya'll object...

please do, I've already Ack'd it for akpm's tree when he sent out the initial cc.

thanks,
grant

Quoted 3 lines

Jeff