Skip to contentSkip to conversation

MPC834x USB patches

PATCH New [email protected] 1 participant 3 messages Sep 28, 2007

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover MPC834x USB patches

MPC834x USB patches. The first is quite serious and would be nice to get in 2.6.23.

--
Bye, Peter Korsgaard

#1 lore raw

PATCH 1/2 Fix mpc834x USB-MPH configuration.

mpc834x USB-MPH configuration got broken by commit 6f442560021aecf08658e26ed9a37e6928ef0fa1. The selection bits in SICRL should be cleared rather than set to configure the USB MUXes for the MPH.

---
 arch/powerpc/platforms/83xx/usb.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/powerpc/platforms/83xx/usb.c +2 -2
Index: linux-2.6.23-rc8/arch/powerpc/platforms/83xx/usb.c
===================================================================
@@ -76,14 +76,14 @@
 			if (port0_is_dr)
 				printk(KERN_WARNING
 					"834x USB port0 can't be used by both DR and MPH!\n");
-			sicrl |= MPC834X_SICRL_USB0;
+			sicrl &= ~MPC834X_SICRL_USB0;
 		}
 		prop = of_get_property(np, "port1", NULL);
 		if (prop) {
 			if (port1_is_dr)
 				printk(KERN_WARNING
 					"834x USB port1 can't be used by both DR and MPH!\n");
-			sicrl |= MPC834X_SICRL_USB1;
+			sicrl &= ~MPC834X_SICRL_USB1;
 		}
 		of_node_put(np);
 	}

--
Bye, Peter Korsgaard

#2 lore raw

PATCH 2/2 mpc8349emitx.dts: Setup USB-DR for peripheral mode.

In reply to [email protected]

Setup dr_mode for USB-DR to peripheral as the default (host mode) doesn't make much sense for the mini-AB connector on the ITX board.

Peripheral mode is preferable to OTG as the fsl_usb2_udc.c driver doesn't yet properly support it.

---
 arch/powerpc/boot/dts/mpc8349emitx.dts |    1 +
 1 file changed, 1 insertion(+)
arch/powerpc/boot/dts/mpc8349emitx.dts +1 -0
Index: linux-2.6.23-rc8/arch/powerpc/boot/dts/mpc8349emitx.dts
===================================================================
@@ -99,6 +99,7 @@
 			#size-cells = <0>;
 			interrupt-parent = < &ipic >;
 			interrupts = <26 8>;
+			dr_mode = "peripheral";
 			phy_type = "ulpi";
 		};
 

--
Bye, Peter Korsgaard