Skip to contentSkip to conversation

z1211: Make the LEDs warning debug-only

PATCH In review Michael Buesch 2 participants 2 messages Sep 29, 2007 – Oct 2, 2007 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 z1211: Make the LEDs warning debug-only

This warning triggers now and then with an -ETIMEDOUT error. Though the LEDs work fine.
Make this warning debug-only, as nobody is really interested in a LED failure that happens only now and then.
If the LEDs don't work, one can easily enable debugging to see what's going on.
This reduces dmesg spamming.

drivers/net/wireless/z1211/zd_mac.c +1 -1
Index: wireless-2.6/drivers/net/wireless/z1211/zd_mac.c
===================================================================
@@ -922,7 +922,7 @@ static void link_led_handler(struct work
 	r = zd_chip_control_leds(chip,
 		                 is_associated ? LED_ASSOCIATED : LED_SCANNING);
 	if (r)
-		dev_err(zd_mac_dev(mac), "zd_chip_control_leds error %d\n", r);
+		dev_dbg_f(zd_mac_dev(mac), "zd_chip_control_leds error %d\n", r);
 
 	queue_delayed_work(zd_workqueue, &mac->housekeeping.link_led_work,
 		           LINK_LED_WORK_DELAY);
Signature · 1 line
Greetings Michael.
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Michael Buesch

This warning triggers now and then with an -ETIMEDOUT error. Though the LEDs work fine.
Make this warning debug-only, as nobody is really interested in a LED failure that happens only now and then.
If the LEDs don't work, one can easily enable debugging to see what's going on.
This reduces dmesg spamming.

Quoted 15 lines

Index: wireless-2.6/drivers/net/wireless/z1211/zd_mac.c
===================================================================

drivers/net/wireless/z1211/zd_mac.c +1 -1
@@ -922,7 +922,7 @@ static void link_led_handler(struct work
 	r = zd_chip_control_leds(chip,
 		                 is_associated ? LED_ASSOCIATED : LED_SCANNING);
 	if (r)
-		dev_err(zd_mac_dev(mac), "zd_chip_control_leds error %d\n", r);
+		dev_dbg_f(zd_mac_dev(mac), "zd_chip_control_leds error %d\n", r);
 
 	queue_delayed_work(zd_workqueue, &mac->housekeeping.link_led_work,
 		           LINK_LED_WORK_DELAY);