Skip to contentSkip to conversation

ACPICA: hw: Don't carry spinlock over suspend

PATCH Andrey Borzenkov 2 participants 2 messages Oct 2, 2007

lore
Share & tools
lore
#0 lore raw
Quoted 9 lines · Alexey Starikovskiy
Quoted 5 lines

ACPI uses acpi_get_register() in order to get into suspend. This function is guarded by acpi_gbl_hardware_lock, which will be carried into resume phase.
At resume interrupts are enabled and first ACPI interrupt deadlocks on this lock.

Ouch. That might have bitten quite some people, I guess.

Quoted 8 lines
Quoted 6 lines

Solution seems to be to not lock register read, as there are no concurrent activity at this point.

Reference: http://bugzilla.kernel.org/show_bug.cgi?id=7499

Do you think it's -stable material?

As someone who *has* been bitten by this bug - by all means.

I'd like to emphasize one more point - we were able to debug it only because old kernel at least displayed debug messages. Current kernel deadlocks absolutely dead (pun intended). No output to console, no indication what happens. I consider this regression. If at all possible, we should make sure that console output is available as early as possible.

#1 lore raw
Quoted 18 lines · Andrey Borzenkov
Quoted 9 lines · Alexey Starikovskiy
Quoted 5 lines

ACPI uses acpi_get_register() in order to get into suspend. This function is guarded by acpi_gbl_hardware_lock, which will be carried into resume phase.
At resume interrupts are enabled and first ACPI interrupt deadlocks on this lock.

Ouch. That might have bitten quite some people, I guess.

Quoted 8 lines
Quoted 6 lines

Solution seems to be to not lock register read, as there are no concurrent activity at this point.

Reference: http://bugzilla.kernel.org/show_bug.cgi?id=7499

Do you think it's -stable material?

Quoted 7 lines

As someone who *has* been bitten by this bug - by all means.

I'd like to emphasize one more point - we were able to debug it only because old kernel at least displayed debug messages. Current kernel deadlocks absolutely dead (pun intended). No output to console, no indication what happens. I consider this regression. If at all possible, we should make sure that console output is available as early as possible.

Compile with DISABLE_CONSOLE_SUSPEND set and it should work.

There's a patch queued up for 2.6.24 that adds a command line switch for that.

Greetings,
Rafael