Avoid possible NULL pointer deref in 3c359 driver
Subsystems (2)
PATCH 4/13 Avoid possible NULL pointer deref in 3c359 driver
From: Jesper Juhl <[email protected]>
In xl_freemem(), if dev_if is NULL, the line
struct xl_private *xl_priv =(struct xl_private *)dev->priv;
will cause a NULL pointer dereference.
(akpm: don't try to fix it: just delete the pointless test-for-null)
Signed-off-by Jesper Juhl <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
---
drivers/net/tokenring/3c359.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/net/tokenring/3c359.c renamed from drivers/net/tokenring/3c359.c~avoid-possible-null-pointer-deref-in-3c359-driver +0 -5
@@ -1045,11 +1045,6 @@ static irqreturn_t xl_interrupt(int irq,u8 __iomem * xl_mmio = xl_priv->xl_mmio ;u16 intstatus, macstatus ; -if (!dev) { -printk (KERN_WARNING "Device structure dead, aaahhhh !\n" ) ; -return IRQ_NONE ; - } - intstatus =readw (xl_mmio +MMIO_INTSTATUS ) ;if (!(intstatus &1 ))/* We didn't generate the interrupt */
_