forcedeth: power down phy when interface is down
Subsystems (2)
PATCH 8/13 forcedeth: power down phy when interface is down
From: "Ed Swierk" <[email protected]>
Bring the physical link down when the interface is down, by placing the PHY in power-down state. This mirrors the behavior of other drivers including e1000 and tg3.
Signed-off-by Ed Swierk <[email protected]>
Cc Ayaz Abdulla <[email protected]>
Cc Jeff Garzik <[email protected]>
Quoted 13 lines · On Sat, 29 Sep 2007 01:57:04 -0400 Jeff Garzik <[email protected]> wrote:
Quoted 10 lines · [email protected] wrote:
From: "Ed Swierk" <[email protected]>
Bring the physical link down when the interface is down, by placing the PHY in power-down state. This mirrors the behavior of other drivers including e1000 and tg3.
Signed-off-by Ed Swierk <[email protected]>Cc Ayaz Abdulla <[email protected]>Cc Jeff Garzik <[email protected]>Signed-off-by Andrew Morton <[email protected]>
Quoted 6 lines
HOLD -- waiting a bit for comment from others, particularly NVIDIA.
I'm not opposed to applying it, the patch looks correct, but I would also like see testing results and general "it's ok for this hardware" comments.
Signed-off-by Andrew Morton <[email protected]>
---
drivers/net/forcedeth.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)
drivers/net/forcedeth.c renamed from drivers/net/forcedeth.c~forcedeth-power-down-phy-when-interface-is-down +10 -2
@@ -1313,9 +1313,9 @@ static int phy_init(struct net_device *d/* some phys clear out pause advertisment on reset, set it back */ mii_rw (dev, np->phyaddr,MII_ADVERTISE , reg); -/* restart auto negotiation */ +/* restart auto negotiation, power down phy */ mii_control =mii_rw (dev, np->phyaddr,MII_BMCR ,MII_READ ); - mii_control |= (BMCR_ANRESTART |BMCR_ANENABLE ); + mii_control |= (BMCR_ANRESTART |BMCR_ANENABLE |BMCR_PDOWN );if (mii_rw (dev, np->phyaddr,MII_BMCR , mii_control)) {return PHY_ERROR ; }
@@ -4791,6 +4791,10 @@ static int nv_open(struct net_device *dedprintk (KERN_DEBUG "nv_open: begin\n" ); +/* power up phy */ +mii_rw (dev, np->phyaddr,MII_BMCR , +mii_rw (dev, np->phyaddr,MII_BMCR ,MII_READ ) & ~BMCR_PDOWN ); +/* erase previous misconfiguration */ if (np->driver_data &DEV_HAS_POWER_CNTRL )nv_mac_reset (dev);
@@ -4975,6 +4979,10 @@ static int nv_close(struct net_device *dnv_start_rx (dev); } +/* power down phy */ +mii_rw (dev, np->phyaddr,MII_BMCR , +mii_rw (dev, np->phyaddr,MII_BMCR ,MII_READ ) |BMCR_PDOWN ); +/* FIXME: power down nic */ return 0 ;
_