Skip to contentSkip to conversation

forcedeth: "no link" is informational

PATCH In review [email protected] 2 participants 2 messages Oct 2, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 9/13 forcedeth: "no link" is informational

From: "Ed Swierk" <[email protected]>

Log "no link during initialization" at KERN_INFO as it's not an error, and occurs every time the interface comes up (when the forcedeth-phy-power-down patch is applied).

---

 drivers/net/forcedeth.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/forcedeth.c renamed from drivers/net/forcedeth.c~forcedeth-no-link-is-informational +1 -1
diff -puN drivers/net/forcedeth.c~forcedeth-no-link-is-informational drivers/net/forcedeth.c
@@ -4921,7 +4921,7 @@ static int nv_open(struct net_device *de
 	if (ret) {
 		netif_carrier_on(dev);
 	} else {
-		printk("%s: no link during initialization.\n", dev->name);
+		printk(KERN_INFO "%s: no link during initialization.\n", dev->name);
 		netif_carrier_off(dev);
 	}
 	if (oom)

_

#1 lore raw
Quoted 19 lines · On Tue, 02 Oct 2007 14:11:41 -0700 [email protected] wrote:

From: "Ed Swierk" <[email protected]>

Log "no link during initialization" at KERN_INFO as it's not an error, and occurs every time the interface comes up (when the forcedeth-phy-power-down patch is applied).

---

 drivers/net/forcedeth.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/net/forcedeth.c~forcedeth-no-link-is-informational drivers/net/forcedeth.c

drivers/net/forcedeth.c static int nv_open(struct net_device *de · line 4927

Quoted 8 lines
drivers/net/forcedeth.c renamed from drivers/net/forcedeth.c~forcedeth-no-link-is-informational +1 -1
@@ -4921,7 +4921,7 @@ static int nv_open(struct net_device *de
 	if (ret) {
 		netif_carrier_on(dev);
 	} else {
-		printk("%s: no link during initialization.\n", dev->name);
+		printk(KERN_INFO "%s: no link during initialization.\n", dev->name);
 		netif_carrier_off(dev);
 	}
 	if (oom)

Driver should use netif_msg_link_up()

Signature · 1 line
Stephen Hemminger <[email protected]>