Skip to contentSkip to conversation

PARTIAL TAKE 971186 - Refactor xfs_mountfs

DISCUSSION [email protected] 1 participant 1 message Oct 4, 2007

lore
Share & tools
lore
#0 lore raw

Refactor xfs_mountfs

Refactoring xfs_mountfs() to call sub-functions for logical chunks can help save a bit of stack, and can make it easier to read this long function.

The mount path is one of the longest common callchains, easily getting to within a few bytes of the end of a 4k stack when over lvm, quotas are enabled, and quotacheck must be done.

With this change on top of the other stack-related changes I've sent, I can get xfs to survive a normal xfsqa run on 4k stacks over lvm.

Date:  Thu Oct  4 16:26:05 AEST 2007
Workarea:  linuxbuild.melbourne.sgi.com:/home/donaldd/isms/2.6.x-xfs
Inspected by:  [email protected]

The following file(s) were checked into:
longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb

Modid: xfs-linux-melb:xfs-kern:29834a
fs/xfs/xfs_mount.c - 1.415 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_mount.c.diff?r1=text&tr1=1.415&r2=text&tr2=1.414&f=h
- Refactor xfs_mountfs