Skip to contentSkip to conversation

Remove unused variable in drivers/dma/ioatdma.c

PATCH In review Johannes Weiner 2 participants 2 messages Oct 7, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove unused variable in drivers/dma/ioatdma.c

Hi,

I found this in an `allyesconfig' build:

CC drivers/dma/ioatdma.o
drivers/dma/ioatdma.c: In function #ioat_dma_free_chan_resources#:
drivers/dma/ioatdma.c:247: warning: unused variable #chanctrl#

Hannes

drivers/dma/ioatdma.c +0 -1
index 41b18c5..d9db64b 100644
@@ -244,7 +244,6 @@ static void ioat_dma_free_chan_resources(struct dma_chan *chan)
 	struct ioat_dma_chan *ioat_chan = to_ioat_chan(chan);
 	struct ioat_device *ioat_device = to_ioat_device(chan->device);
 	struct ioat_desc_sw *desc, *_desc;
-	u16 chanctrl;
 	int in_use_descs = 0;
 
 	ioat_dma_memcpy_cleanup(ioat_chan);
#1 lore raw

From: Johannes Weiner <[email protected]>
Date: Sun, 7 Oct 2007 21:18:49 +0200

Quoted 11 lines

Hi,

I found this in an `allyesconfig' build:

CC drivers/dma/ioatdma.o
drivers/dma/ioatdma.c: In function #ioat_dma_free_chan_resources#:
drivers/dma/ioatdma.c:247: warning: unused variable #chanctrl#

Hannes

This exists as a patch in -mm for what seems like months.

I can't believe this one-liner hasn't been merged yet, it's silly.

I was even chastised at one point for merging it into my net-2.6.24 tree :-)