Skip to contentSkip to conversation

hwmon/lm87: Fix a division by zero

PATCH In review Jean Delvare 3 participants 3 messages Sep 26, 2007 – Oct 7, 2007 Hardware monitoring

lore
Share & tools
lore

Jean Delvare

author
#0 lore raw

PATCH 1/1 hwmon/lm87: Fix a division by zero

Missing parentheses in the definition of FAN_FROM_REG cause a division by zero for a specific register value.

Signed-off-by Jean Delvare <[email protected]>
---
 drivers/hwmon/lm87.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/lm87.c +1 -1
@@ -129,7 +129,7 @@ static u8 LM87_REG_TEMP_LOW[3] = { 0x3A,
 				 (((val) < 0 ? (val)-500 : (val)+500) / 1000))
 
 #define FAN_FROM_REG(reg,div)	((reg) = 255 || (reg) = 0 ? 0 : \
-				 1350000 + (reg)*(div) / 2) / ((reg)*(div))
+				 (1350000 + (reg)*(div) / 2) / ((reg)*(div)))
 #define FAN_TO_REG(val,div)	((val)*(div) * 255 <= 1350000 ? 255 : \
 				 (1350000 + (val)*(div) / 2) / ((val)*(div)))
Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Acked-by on v1 1/1
#1 lore raw

Hi All,

In this post:
http://lists.lm-sensors.org/pipermail/lm-sensors/2007-September/021288.html

Jean Delvare wrote:
--------------------------------------------
Missing parentheses in the definition of FAN_FROM_REG cause a division by zero for a specific register value.

Signed-off-by Jean Delvare <khali at linux-fr.org>
---
  drivers/hwmon/lm87.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/lm87.c +1 -1
@@ -129,7 +129,7 @@ static u8 LM87_REG_TEMP_LOW[3] = { 0x3A,
  				 (((val) < 0 ? (val)-500 : (val)+500) / 1000))
 
  #define FAN_FROM_REG(reg,div)	((reg) = 255 || (reg) = 0 ? 0 : \
-				 1350000 + (reg)*(div) / 2) / ((reg)*(div))
+				 (1350000 + (reg)*(div) / 2) / ((reg)*(div)))
  #define FAN_TO_REG(val,div)	((val)*(div) * 255 <= 1350000 ? 255 : \
  				 (1350000 + (val)*(div) / 2) / ((val)*(div)))

--------------------------------------------
Looks good:

Acked-by Hans de Goede <[email protected]>

Regards,

Hans

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#2 lore raw
In reply to Jean Delvare

Hi:

Quoted 11 lines · Hans de Goede

Hi All,

In this post:
http://lists.lm-sensors.org/pipermail/lm-sensors/2007-September/021288.html

Jean Delvare wrote:
--------------------------------------------
Missing parentheses in the definition of FAN_FROM_REG cause a division by zero for a specific register value.

Signed-off-by Jean Delvare <khali at linux-fr.org>

(...)

Quoted 1 line
Acked-by Hans de Goede <[email protected]>

Applied to hwmon-2.6.git/testing, thanks.

Signature · 8 lines
Mark M. Hoffman
[email protected]


_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors