ath5k: initvals, radar, promiscuous bug and multicast

NACK i have a better fix wich uses chip srev, i had commited it on ath5k branch on madwifi svn...

what's going on ? noone read my chagnes n ath5k branch on madwifi svn ? i did this change some time ago (over a month) and it seems you didn't even saw it...

http://madwifi.org/changeset/2703
http://madwifi.org/changeset/2704

what happened to my changes ? you told me you would commit them here...

Quoted 11 lines

NACK i have a better fix wich uses chip srev, i had commited it on ath5k branch on madwifi svn...

what's going on ? noone read my chagnes n ath5k branch on madwifi svn ? i did this change some time ago (over a month) and it seems you didn't even saw it...

http://madwifi.org/changeset/2703
http://madwifi.org/changeset/2704

what happened to my changes ? you told me you would commit them here...

I had said I would but Jiri sent some patches based on your work which I thought included your latest changes. Instead of bitching about things you should start sending patches, that would be more helpful.

Anyway I actually like that approach more, thanks. John -- I'll send in a new patch series.

Luis

You are right but i was on a trip

I'll try again wireless-dev and I'll send a
patch series here.

Quoted 1 line

You are right but i was on a trip

...

Quoted 2 lines

I'll try again wireless-dev and I'll send a
patch series here.

If you were away you might not have heard that wireless-dev is dead. Use wireless-2.6 instead.

The chance that this boots is higher :-)

+ * Note that this is a simple filter and *does* not filter out all
+ * relevant frames. Some non-relevant frames will get through, probability
+ * jocks are welcomed to compute.

+ * IFRAME-05: 1101 --> allowed but its not for us!!!

drivers/net/wireless/ath5k/base.c static void ath_configure_filter(struct ieee80211_hw *hw, · line 1489

Quoted 4 lines · Luis R. Rodriguez

drivers/net/wireless/ath5k/base.c +4 -0

+     /* FIF_CONTROL doc says that if FIF_PROMISC_IN_BSS is not
+      * set we should only pass on control frames for this
+      * station. This needs testing. I believe right now this
+      * enables *all* control frames */

Which is fine too, but not most efficient. Remember that the docs also say you can pass up more frames, so an implementation that passes up *all* frames at all times is correct in that it supports all filter flags; it is, however, rather inefficient.

Enable radar detection, and clean up ath5k_hw_attach() definition.

Specifically this patch:

o On struct ath_hw:
* renames ah_sh to ah_iobase to make its use clear
* move ah_sc to non-opaque struct, as we only currently use it as struct ath_softc. We we add SoC support we can figure an alternative.
* Move out radar struct definition into new struct ath_radar

o On ath5k_hw_attach() we currenlty pass the ath_sofct struct and sc->iobase. No point in passing both since we're already passing sc.

o Remove any comments referring to a "HAL". We don't have one anymore. Another patch later will replace 'hal' -> 'ahw'.

o On ath5k_hw_get_isr() only read AR5K_RAC_PISR on non-AR5210s

o Capture AR5K_IMR_RXPHY and pass it as AR5K_INT_RXPHY to our interrupt handler. Upon detection call ath5k_radar_alert(). Upper layers need radar detection handling support. Right now just announce detection. We enable radar detection through new ath5k_hw_enable_radar_alert().

Changes to ath5k_base.[ch]
Changes-licensed-under: 3-clause-BSD

Changes to ath5k.h, hw.c
Changes-licensed-under: ISC

Signed-off-by Luis R. Rodriguez <[email protected]>

---
 drivers/net/wireless/ath5k/ath5k.h |   65 +++++++++++++++++--------------
 drivers/net/wireless/ath5k/base.c  |   44 ++++++++++++++++-----
 drivers/net/wireless/ath5k/base.h  |    2 +-
 drivers/net/wireless/ath5k/hw.c    |   74 +++++++++++++++++++++++++++++-------
 4 files changed, 130 insertions(+), 55 deletions(-)

drivers/net/wireless/ath5k/ath5k.h +36 -29

index 9308916..445fde8 100644
@@ -274,10 +274,10 @@ enum ath5k_tx_queue_subtype {
 };
 
 /*
- * Queue ID numbers as returned by the HAL, each number
- * represents a hw queue. If hw does not support hw queues
- * (eg 5210) all data goes in one queue. These match
- * d80211 definitions (net80211/MadWiFi don't use them).
+ * Queue ID numbers as used by ath5k_hw_setup_tx_queue() and
+ * ath5k_hw_wait_for_beacon(). Each number represents a hw queue.
+ * If hw does not support hw queues (eg 5210) all data goes in one
+ * queue. These match mac0211 definitions.
  */
 enum ath5k_tx_queue_id {
        AR5K_TX_QUEUE_ID_NOQCU_DATA     = 0,

@@ -323,7 +323,8 @@ struct ath5k_txq_info {
 
 /*
  * Transmit packet types.
- * These are not fully used inside OpenHAL yet
+ * These are currently only used in ath5k_hw_setup_2word_tx_desc() to
+ * distinguish frame types on AR5210.
  */
 enum ath5k_pkt_type {
        AR5K_PKT_TYPE_NORMAL            = 0,

@@ -573,8 +574,7 @@ struct ath_desc {
 #define CHANNEL_MODES          CHANNEL_ALL
 
 /*
- * Used internaly in OpenHAL (ar5211.c/ar5212.c
- * for reset_tx_queue). Also see struct struct ieee80211_channel.
+ * Used internaly in ath5k_hw_reset_tx_queue()
  */
 #define IS_CHAN_XR(_c) ((_c.val & CHANNEL_XR) != 0)
 #define IS_CHAN_B(_c)  ((_c.val & CHANNEL_B) != 0)

@@ -717,13 +717,14 @@ enum ath5k_ant_setting {
 };
 
 /*
- * HAL interrupt abstraction
+ * Hardware interrupt masks helpers
  */
 
 /*
  * These are mapped to take advantage of some common bits
  * between the MAC chips, to be able to set intr properties
- * easier. Some of them are not used yet inside OpenHAL.
+ * easier. Some of them are not used yet inside hw.c. Most map
+ * to the respective hw interrupt value.
  */
 enum ath5k_int {
        AR5K_INT_RX     = 0x00000001,

@@ -773,8 +774,8 @@ enum ath5k_power_mode {
 };
 
 /*
- * These match net80211 definitions (not used in
- * d80211).
+ * These match net80211 definitions
+ * XXX: move to mac80211 led work
  */
 #define AR5K_LED_INIT  0 /*IEEE80211_S_INIT*/
 #define AR5K_LED_SCAN  1 /*IEEE80211_S_SCAN*/

@@ -788,9 +789,8 @@ enum ath5k_power_mode {
 #define AR5K_SOFTLED_OFF       1
 
 /*
- * Chipset capabilities -see ath_hal_getcapability-
- * get_capability function is not yet fully implemented
- * in OpenHAL so most of these don't work yet...
+ * Chipset capabilities. See ath5k_hw_get_capability(),
+ * we do what we can as we make progress
  */
 enum ath5k_capability_type {
        AR5K_CAP_REG_DMN                = 0,    /* Used to get current reg. domain id */

@@ -862,14 +862,20 @@ struct ath5k_capabilities {
  * Misc defines
  */
 
+struct ath_radar {
+       bool    r_enabled;
+       int     r_last_alert;
+       struct ieee80211_channel r_last_channel;
+};
+
 #define AR5K_MAX_GPIO          10
 #define AR5K_MAX_RF_BANKS      8
 
 struct ath_hw {
        u32                     ah_magic;
 
-       void                    *ah_sc;
-       void __iomem            *ah_sh;
+       struct ath_softc        *ah_sc;
+       void __iomem            *ah_iobase;
        enum ath5k_countrycode  ah_country_code;
 
        enum ath5k_int          ah_imr;

@@ -937,11 +943,7 @@ struct ath_hw {
                s16             txp_ofdm;
        } ah_txpower;
 
-       struct {
-               bool            r_enabled;
-               int             r_last_alert;
-               struct ieee80211_channel r_last_channel;
-       } ah_radar;
+       struct ath_radar        ah_radar;
 
        /*
         * Function pointers

@@ -966,7 +968,8 @@ struct ath_hw {
 /* General Functions */
 extern int ath5k_hw_register_timeout(struct ath_hw *hal, u32 reg, u32 flag, u32 val, bool is_set);
 /* Attach/Detach Functions */
-extern struct ath_hw *ath5k_hw_attach(u16 device, u8 mac_version, void *sc, void __iomem *sh);
+extern struct ath_hw *ath5k_hw_attach(u16 device, u8 mac_version,
+       struct ath_softc *sc);
 extern const struct ath5k_rate_table *ath5k_hw_get_rate_table(struct ath_hw *hal, unsigned int mode);
 extern void ath5k_hw_detach(struct ath_hw *hal);
 /* Reset Functions */

@@ -981,12 +984,15 @@ extern void ath5k_hw_put_rx_buf(struct ath_hw *hal, u32 phys_addr);
 extern int ath5k_hw_tx_start(struct ath_hw *hal, unsigned int queue);
 extern int ath5k_hw_stop_tx_dma(struct ath_hw *hal, unsigned int queue);
 extern u32 ath5k_hw_get_tx_buf(struct ath_hw *hal, unsigned int queue);
-extern int ath5k_hw_put_tx_buf(struct ath_hw *hal, unsigned int queue, u32 phys_addr);
+extern int ath5k_hw_put_tx_buf(struct ath_hw *hal, unsigned int queue,
+       u32 phys_addr);
 extern int ath5k_hw_update_tx_triglevel(struct ath_hw *hal, bool increase);
 /* Interrupt handling */
 extern bool ath5k_hw_is_intr_pending(struct ath_hw *hal);
 extern int ath5k_hw_get_isr(struct ath_hw *hal, enum ath5k_int *interrupt_mask);
-extern enum ath5k_int ath5k_hw_set_intr(struct ath_hw *hal, enum ath5k_int new_mask);
+extern enum ath5k_int ath5k_hw_set_intr(struct ath_hw *hal,
+       enum ath5k_int new_mask);
+extern void ath5k_hw_enable_radar_alert(struct ath_hw *hal, bool enable);
 /* EEPROM access functions */
 extern int ath5k_hw_set_regdomain(struct ath_hw *hal, u16 regdomain);
 /* Protocol Control Unit Functions */

@@ -994,7 +1000,8 @@ extern int ath5k_hw_set_opmode(struct ath_hw *hal);
 /* BSSID Functions */
 extern void ath5k_hw_get_lladdr(struct ath_hw *hal, u8 *mac);
 extern int ath5k_hw_set_lladdr(struct ath_hw *hal, const u8 *mac);
-extern void ath5k_hw_set_associd(struct ath_hw *hal, const u8 *bssid, u16 assoc_id);
+extern void ath5k_hw_set_associd(struct ath_hw *hal,
+       const u8 *bssid, u16 assoc_id);
 extern int ath5k_hw_set_bssid_mask(struct ath_hw *hal, const u8 *mask);
 /* Receive start/stop functions */
 extern void ath5k_hw_start_rx_pcu(struct ath_hw *hal);

@@ -1073,14 +1080,14 @@ extern int ath5k_hw_txpower(struct ath_hw *hal, struct ieee80211_channel *channe
 extern int ath5k_hw_set_txpower_limit(struct ath_hw *hal, unsigned int power);
 
 
-static inline u32 ath5k_hw_reg_read(struct ath_hw *hal, u16 reg)
+static inline u32 ath5k_hw_reg_read(struct ath_hw *ahw, u16 reg)
 {
-       return ioread32(hal->ah_sh + reg);
+       return ioread32(ahw->ah_iobase + reg);
 }
 
-static inline void ath5k_hw_reg_write(struct ath_hw *hal, u32 val, u16 reg)
+static inline void ath5k_hw_reg_write(struct ath_hw *ahw, u32 val, u16 reg)
 {
-       iowrite32(val, hal->ah_sh + reg);
+       iowrite32(val, ahw->ah_iobase + reg);
 }
 
 #endif

drivers/net/wireless/ath5k/base.c +33 -11

index afcc7e1..fa591eb 100644
@@ -114,9 +114,8 @@ module_param_named(debug, ath_debug, uint, 0);
 #endif
 
 /*
- * User a static table of PCI id's for now.  While this is the
- * "new way" to do things, we may want to switch back to having
- * the HAL check them by defining a probe method.
+ * ath5k_hw_attach() may also do further checking. Some devices keep the same
+ * PCI vendor:device ID but may differ. ath5k_hw_attach() will check there.
  */
 static struct pci_device_id ath_pci_id_table[] __devinitdata = {
        { PCI_VDEVICE(ATHEROS, 0x0207), .driver_data = AR5K_AR5210 }, /* 5210 early */

@@ -596,7 +595,7 @@ static void ath_beacon_send(struct ath_softc *sc)
        if (unlikely(ath5k_hw_stop_tx_dma(ah, sc->bhalq))) {
                printk(KERN_WARNING "ath: beacon queue %u didn't stop?\n",
                                sc->bhalq);
-               /* NB: the HAL still stops DMA, so proceed */
+               /* ath5k_hw_stop_tx_dma() still stops DMA, so proceed */
        }
        pci_dma_sync_single_for_cpu(sc->pdev, bf->skbaddr, bf->skb->len,
                        PCI_DMA_TODEVICE);

@@ -717,6 +716,8 @@ static void ath_beacon_config(struct ath_softc *sc)
                                ath5k_hw_hasveol(ah))
                        ath_beacon_send(sc);
        }
+       /* Enable radar alerts */
+       ath5k_hw_enable_radar_alert(ah, true);
 #undef TSF_TO_TU
 }
 

@@ -1135,7 +1136,7 @@ static int ath_chan_set(struct ath_softc *sc, struct ieee80211_channel *chan)
                 *
                 * XXX needed?
                 */
-/*             ath_chan_change(sc, chan); */
+               //ath_chan_set(sc, sc->curchan);
 
                /*
                 * Re-enable interrupts.

@@ -1260,10 +1261,6 @@ static int ath_reset(struct ieee80211_hw *hw)
        int ret;
 
        DPRINTF(sc, ATH_DEBUG_RESET, "resetting\n");
-       /*
-        * Convert to a HAL channel description with the flags
-        * constrained to reflect the current operating mode.
-        */
        sc->curchan = hw->conf.chan;
 
        ath5k_hw_set_intr(ah, 0);

@@ -1289,7 +1286,7 @@ static int ath_reset(struct ieee80211_hw *hw)
         *
         * XXX needed?
         */
-/*     ath_chan_change(sc, c); */
+       //ath_chan_set(sc, sc->curchan);
        ath_beacon_config(sc);
        /* intrs are started by ath_beacon_config */
 

@@ -1669,6 +1666,28 @@ static void ath_led_event(struct ath_softc *sc, int event)
        }
 }
 
+static void ath5k_radar_alert(struct ath_hw *ahw)
+{
+       struct ath_radar *radar = &ahw->ah_radar;
+       struct ieee80211_channel *radar_chan = &radar->r_last_channel;
+       struct ieee80211_channel *curr_chan = &ahw->ah_current_channel;
+
+       /* Limit ~1/s */
+       if (radar_chan->chan == curr_chan->chan &&
+               jiffies < (radar->r_last_alert + 1 * HZ))
+       return;
+
+       memcpy(radar_chan, curr_chan, sizeof(struct ieee80211_channel));
+       radar->r_last_alert = jiffies;
+
+       dev_info(&ahw->ah_sc->pdev->dev,
+               "Possible radar activity detected at "
+               "%u MHz (jiffies %u)\n", radar->r_last_alert,
+               curr_chan->chan);
+
+       /* Higher layer should probably do something here... TBC */
+}
+
 static irqreturn_t ath_intr(int irq, void *dev_id)
 {
        struct ath_softc *sc = dev_id;

@@ -1701,6 +1720,9 @@ static irqreturn_t ath_intr(int irq, void *dev_id)
                        tasklet_schedule(&sc->restq);
                } else if (unlikely(status & AR5K_INT_RXORN)) {
                        tasklet_schedule(&sc->restq);
+               } else if ((unlikely(status & AR5K_INT_RXPHY)) &&
+                       ah->ah_radar.r_enabled) {
+                               ath5k_radar_alert(ah);
                } else {
                        if (status & AR5K_INT_SWBA) {
                                /*

@@ -2373,7 +2395,7 @@ static int __devinit ath_pci_probe(struct pci_dev *pdev,
                goto err_free;
        }
 
-       sc->ah = ath5k_hw_attach(pdev->device, id->driver_data, sc, sc->iobase);
+       sc->ah = ath5k_hw_attach(pdev->device, id->driver_data, sc);
        if (IS_ERR(sc->ah)) {
                ret = PTR_ERR(sc->ah);
                goto err_irq;

drivers/net/wireless/ath5k/base.h +1 -1

index 4a624cc..1bd1d1f 100644
@@ -191,7 +191,7 @@ struct ath_softc {
        struct tasklet_struct   txtq;           /* tx intr tasklet */
 
        struct ath_buf          *bbuf;          /* beacon buffer */
-       unsigned int            bhalq,          /* HAL q for outgoing beacons */
+       unsigned int            bhalq,          /* Hw q for outgoing beacons */
                                bmisscount,     /* missed beacon transmits */
                                bintval,        /* beacon interval */
                                bsent;

drivers/net/wireless/ath5k/hw.c +60 -15

index ae4c5b5..6ef492c 100644
@@ -21,7 +21,7 @@
  */
 
 /*
- * HAL interface for Atheros Wireless LAN devices.
+ * Hardware interface for Atheros Wireless LAN devices.
  */
 
 #include <linux/pci.h>

@@ -29,6 +29,7 @@
 
 #include "ath5k.h"
 #include "reg.h"
+#include "base.h"
 
 /*Rate tables*/
 static const struct ath5k_rate_table ath5k_rt_11a = AR5K_RATES_11A;

@@ -191,8 +192,8 @@ int ath5k_hw_register_timeout(struct ath_hw *hal, u32 reg, u32 flag, u32 val,
 /*
  * Check if the device is supported and initialize the needed structs
  */
-struct ath_hw *ath5k_hw_attach(u16 device, u8 mac_version, void *sc,
-               void __iomem *sh)
+struct ath_hw *ath5k_hw_attach(u16 device,
+       u8 mac_version, struct ath_softc *sc)
 {
        struct ath_hw *hal;
        u8 mac[ETH_ALEN];

@@ -208,10 +209,10 @@ struct ath_hw *ath5k_hw_attach(u16 device, u8 mac_version, void *sc,
        }
 
        hal->ah_sc = sc;
-       hal->ah_sh = sh;
+       hal->ah_iobase = sc->iobase;
 
        /*
-        * HAL information
+        * Hardware cached data
         */
 
        /* Regulation Stuff */

@@ -1474,14 +1475,15 @@ int ath5k_hw_get_isr(struct ath_hw *hal, enum ath5k_int *interrupt_mask)
                        return -ENODEV;
                }
        }
+       else {
+               /*
+                * Read interrupt status from the Read-And-Clear shadow register
+                */
+               data = ath5k_hw_reg_read(hal, AR5K_RAC_PISR);
+       }
 
        /*
-        * Read interrupt status from the Read-And-Clear shadow register
-        */
-       data = ath5k_hw_reg_read(hal, AR5K_RAC_PISR);
-
-       /*
-        * Get abstract interrupt mask (HAL-compatible)
+        * Get abstract interrupt mask
         */
        *interrupt_mask = (data & AR5K_INT_COMMON) & hal->ah_imr;
 

@@ -1494,6 +1496,9 @@ int ath5k_hw_get_isr(struct ath_hw *hal, enum ath5k_int *interrupt_mask)
        if (data & (AR5K_ISR_TXOK | AR5K_ISR_TXERR))
                *interrupt_mask |= AR5K_INT_TX;
 
+       if (data & AR5K_IMR_RXPHY)
+               *interrupt_mask |= AR5K_INT_RXPHY;
+
        if (hal->ah_version != AR5K_AR5210) {
                /*HIU = Host Interface Unit (PCI etc)*/
                if (unlikely(data & (AR5K_ISR_HIUERR)))

@@ -1504,12 +1509,14 @@ int ath5k_hw_get_isr(struct ath_hw *hal, enum ath5k_int *interrupt_mask)
                        *interrupt_mask |= AR5K_INT_BNR;
        }
 
+#if 0
        /*
         * XXX: BMISS interrupts may occur after association.
-        * I found this on 5210 code but it needs testing
+        * Needs testing.
         */
-#if 0
-       interrupt_mask &= ~AR5K_INT_BMISS;
+       if (hal->ah_version != AR5K_AR5210) {
+               interrupt_mask &= ~AR5K_INT_BMISS;
+       }
 #endif
 
        /*

@@ -1570,6 +1577,45 @@ enum ath5k_int ath5k_hw_set_intr(struct ath_hw *hal, enum ath5k_int new_mask)
        return old_mask;
 }
 
+/*
+ * Enable HW radar detection
+ */
+void ath5k_hw_enable_radar_alert(struct ath_hw *ahw, bool enable)
+{
+
+       AR5K_TRACE;
+       /*
+        * Enable radar detection
+        */
+
+       /* Disable interupts */
+       ath5k_hw_reg_write(ahw, AR5K_IER_DISABLE, AR5K_IER);
+
+       /*
+        * Set the RXPHY interrupt to be able to detect
+        * possible radar activity.
+        */
+       if (ahw->ah_version == AR5K_AR5210) {
+               if (enable)
+                       AR5K_REG_ENABLE_BITS(ahw, AR5K_IMR, AR5K_IMR_RXPHY);
+               else
+                       AR5K_REG_DISABLE_BITS(ahw, AR5K_IMR, AR5K_IMR_RXPHY);
+       } else {
+               /* Also set AR5K_PHY_RADAR register on 5111/5112 */
+               if (enable) {
+                       ath5k_hw_reg_write(ahw, AR5K_PHY_RADAR_ENABLE,
+                               AR5K_PHY_RADAR);
+                       AR5K_REG_ENABLE_BITS(ahw, AR5K_PIMR, AR5K_IMR_RXPHY);
+               } else {
+                       ath5k_hw_reg_write(ahw, AR5K_PHY_RADAR_DISABLE,
+                               AR5K_PHY_RADAR);
+                       AR5K_REG_DISABLE_BITS(ahw, AR5K_PIMR, AR5K_IMR_RXPHY);
+               }
+       }
+
+       /* Re-enable interrupts */
+       ath5k_hw_reg_write(ahw, AR5K_IER_ENABLE,  AR5K_IER);
+}
 
 /*************************\
   EEPROM access functions
--

1.5.2.5

Take a look here..
http://thread.gmane.org/gmane.linux.drivers.madwifi.devel/4386/focus=4391

So far I haven't received one AR5K_INT_RXPHY interrupt yet. Mind you we are already setting radar to 1 too -- we do this at the end of ath_reset() with ath5k_hw_enable_radar_alert() -- so not sure what's going on. I do live in front of a cemetery...

Anyway IMO we shouldn't handle radar detection but simply pass it down
to the upper layers, in this case mac80211. It seems for DFS this
would mean to force to change channels and blacklist the channel for
30 minutes. If this interrupt *does* prove to be very noisy we can simply disable the AR5K_RX_FILTER_RADARERR and even AR5K_RX_FILTER_PHYERR later. Perhaps AR5K_RX_FILTER_RADARERR should be enabled during
configure_filter() through mac80211 to indicate when we do *need* DFS.
Right now AR5K_RX_FILTER_PHYERR is enabled when mac80211 tells us
about FIF_FCSFAIL | FIF_PLCPFAIL, we also keep the current hw settings on AR5K_PHY_ERR_FIL (AR5K_PHY_ERR_FIL_RADAR, AR5K_PHY_ERR_FIL_OFDM or AR5K_PHY_ERR_FIL_CCK).

Comments?

Luis

There's an airport less
than 1 mile away and I've never detected true radar.

Quoted 2 lines

There's an airport less
than 1 mile away and I've never detected true radar.

Maybe you need to go to some russian military camp. Some russian surface-to-air missile systems used (20 years ago) frequency ranges in the 5 GHz area.

Quoted 6 lines · Holger Schurig

Quoted 2 lines

There's an airport less
than 1 mile away and I've never detected true radar.

Maybe you need to go to some russian military camp. Some russian surface-to-air missile systems used (20 years ago) frequency ranges in the 5 GHz area.

Indeed, I'm told most radars use 10GHz these days.

Ported new initval changes from OpenBSD to ath5k to ar5212_ini[] and ar5212_ini_mode[].

This also adds an O(log(N)) bitswap for one byte on ath5k_hw_bitswap(), thanks to Tom from OpenBSD.

2007/10/5, Luis R. Rodriguez <[email protected]>:

Quoted 2 lines

Ported new initval changes from OpenBSD to ath5k to ar5212_ini[] and ar5212_ini_mode[].

NACK

Nothing new was introduced in OpenBSD cvs that i haven't already included!, what have you ported ???

Quoted 2 lines

This also adds an O(log(N)) bitswap for one byte on ath5k_hw_bitswap(), thanks to Tom from OpenBSD.

ACK it's used for modifying rf buffer settings...

Quoted 8 lines

2007/10/5, Luis R. Rodriguez <[email protected]>:

Quoted 2 lines

Ported new initval changes from OpenBSD to ath5k to ar5212_ini[] and ar5212_ini_mode[].

NACK

Nothing new was introduced in OpenBSD cvs that i haven't already included!, what have you ported ???

Actually, you are right, an oversight by my part. Thanks for catching this. However after verying this I did find the one type. Please review.

Quoted 4 lines

Quoted 2 lines

This also adds an O(log(N)) bitswap for one byte on ath5k_hw_bitswap(), thanks to Tom from OpenBSD.

ACK it's used for modifying rf buffer settings...

I think its easier to just new patches. I'll do so but please first review the small change below.

Luis

drivers/net/wireless/ath5k/reg.h +0 -0

index 1537517..f826422 100644

I'll post a pach series asap here with my fixes against current wireless-dev including your fixes on base.c/h and any other fixes

Quoted 2 lines

I'll post a pach series asap here with my fixes against current wireless-dev including your fixes on base.c/h and any other fixes

Just a note, wireless-2.6 is current wireless tree.

This patch series adds a few things which have been sitting in my queue. The most important change is the proper fix for the promiscuous bug.