race between open and disconnect in irda-usb
Subsystems (2)
PATCH 1/1 race between open and disconnect in irda-usb
Hi,
it seems to me that irda_usb_net_open() must set self->netopen under spinlock or disconnect() may fail to kill all URBs, if it is called while an interface is opened.
Regards
Oliver
----
drivers/net/irda/irda-usb.c +5 -0
@@ -1168,6 +1168,7 @@ static int stir421x_patch_device(structstatic int irda_usb_net_open (struct net_device *netdev) {struct irda_usb_cb *self; +unsigned long flags;char hwname[16 ];int i;
@@ -1177,13 +1178,16 @@ static int irda_usb_net_open(struct net_ self = (struct irda_usb_cb *) netdev->priv; IRDA_ASSERT(self != NULL, return -1;); +spin_lock_irqsave (&self->lock, flags);/* Can only open the device if it's there */ if (!self->present) { +spin_unlock_irqrestore (&self->lock, flags);IRDA_WARNING ("%s(), device not present!\n" , __FUNCTION__);return -1 ; }if (self->needspatch) { +spin_unlock_irqrestore (&self->lock, flags);IRDA_WARNING ("%s(), device needs patch\n" , __FUNCTION__) ;return -EIO ; }
@@ -1198,6 +1202,7 @@ static int irda_usb_net_open(struct net_/* To do *before* submitting Rx urbs and starting net Tx queue * Jean II */ self->netopen =1 ; +spin_unlock_irqrestore (&self->lock, flags);/* * Now that everything should be initialized properly,
A message that is not in the archive (sent off-list or not yet received): 200710121053.55829.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org
Hi Oliver,
Quoted 5 lines · Oliver Neukum
Hi,
it seems to me that
irda_usb_net_open()must setself->netopenunder spinlock ordisconnect()may fail to kill all URBs, if it is called while an interface is opened.
Makes sense, yes.
I will push it upstream with my next IrDA update.
Cheers,
Samuel.
Quoted 45 lines
Signed-off-by Oliver Neukum <[email protected]>Regards
Oliver----
drivers/net/irda/irda-usb.c +5
-1@@ -1168,6 +1168,7 @@ static int stir421x_patch_device(structstatic int irda_usb_net_open (struct net_device *netdev) {struct irda_usb_cb *self; +unsigned long flags;char hwname[16 ];int i;@@ -1177,13 +1178,16 @@ static int irda_usb_net_open(struct net_ self = (struct irda_usb_cb *) netdev->priv; IRDA_ASSERT(self != NULL, return -1;); +spin_lock_irqsave (&self->lock, flags);/* Can only open the device if it's there */ if (!self->present) { +spin_unlock_irqrestore (&self->lock, flags);IRDA_WARNING ("%s(), device not present!\n" , __FUNCTION__);return -1 ; }if (self->needspatch) { +spin_unlock_irqrestore (&self->lock, flags);IRDA_WARNING ("%s(), device needs patch\n" , __FUNCTION__) ;return -EIO ; }@@ -1198,6 +1202,7 @@ static int irda_usb_net_open(struct net_/* To do *before* submitting Rx urbs and starting net Tx queue * Jean II */ self->netopen =1 ; +spin_unlock_irqrestore (&self->lock, flags);/* * Now that everything should be initialized properly, -------------------------------------------------------------------------
Quoted 8 lines
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
irda-users mailing list [email protected]
http://lists.sourceforge.net/lists/listinfo/irda-users
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/