Skip to contentSkip to conversation

iwl3945: cleanup namespace

PATCH In review Christoph Hellwig 2 participants 3 messages Oct 12, 2007 – Oct 25, 2007 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iwl3945: cleanup namespace

prefix all symbols with iwl3945_ and thus allow building the driver into the kernel. Also remove all the useless default statements in Kconfig while we're at it.

drivers/net/wireless/iwlwifi/iwl-3945-debug.h +6 -6
Index: linux-2.6/drivers/net/wireless/iwlwifi/iwl-3945-debug.h
===================================================================
@@ -26,18 +26,18 @@
  *
  *****************************************************************************/
 
-#ifndef __iwl_debug_h__
-#define __iwl_debug_h__
+#ifndef __iwl3945_debug_h__
+#define __iwl3945_debug_h__
 
 #ifdef CONFIG_IWL3945_DEBUG
-extern u32 iwl_debug_level;
+extern u32 iwl3945_debug_level;
 #define IWL_DEBUG(level, fmt, args...) \
-do { if (iwl_debug_level & (level)) \
+do { if (iwl3945_debug_level & (level)) \
   printk(KERN_ERR DRV_NAME": %c %s " fmt, \
 	 in_interrupt() ? 'I' : 'U', __FUNCTION__ , ## args); } while (0)
 
 #define IWL_DEBUG_LIMIT(level, fmt, args...) \
-do { if ((iwl_debug_level & (level)) && net_ratelimit()) \
+do { if ((iwl3945_debug_level & (level)) && net_ratelimit()) \
   printk(KERN_ERR DRV_NAME": %c %s " fmt, \
 	 in_interrupt() ? 'I' : 'U', __FUNCTION__ , ## args); } while (0)
 #else
@@ -68,7 +68,7 @@ static inline void IWL_DEBUG_LIMIT(int l
  *
  * % cat /proc/net/iwl/debug_level
  *
- * you simply need to add your entry to the iwl_debug_levels array.
+ * you simply need to add your entry to the iwl3945_debug_levels array.
  *
  * If you do not see debug_level in /proc/net/iwl then you do not have
  * CONFIG_IWL3945_DEBUG defined in your kernel configuration
drivers/net/wireless/iwlwifi/iwl-3945-hw.h +121 -121

745 lines not on this page · raw message

drivers/net/wireless/iwlwifi/iwl-3945-io.h +136 -136

518 lines not on this page · raw message

drivers/net/wireless/iwlwifi/iwl-3945-rs.c +73 -73

460 lines not on this page · raw message

drivers/net/wireless/iwlwifi/iwl-3945-rs.h +15 -15
Index: linux-2.6/drivers/net/wireless/iwlwifi/iwl-3945-rs.h
===================================================================
@@ -24,10 +24,10 @@
  *
  *****************************************************************************/
 
-#ifndef __iwl_3945_rs_h__
-#define __iwl_3945_rs_h__
+#ifndef __iwl3945_3945_rs_h__
+#define __iwl3945_3945_rs_h__
 
-struct iwl_rate_info {
+struct iwl3945_rate_info {
 	u8 plcp;
 	u8 ieee;
 	u8 prev_ieee;		/* previous rate in IEEE speeds */
@@ -140,11 +140,11 @@ enum {
 #define IWL_MIN_RSSI_VAL                 -100
 #define IWL_MAX_RSSI_VAL                    0
 
-extern const struct iwl_rate_info iwl_rates[IWL_RATE_COUNT];
+extern const struct iwl3945_rate_info iwl3945_rates[IWL_RATE_COUNT];
 
-static inline u8 iwl_get_prev_ieee_rate(u8 rate_index)
+static inline u8 iwl3945_get_prev_ieee_rate(u8 rate_index)
 {
-	u8 rate = iwl_rates[rate_index].prev_ieee;
+	u8 rate = iwl3945_rates[rate_index].prev_ieee;
 
 	if (rate == IWL_RATE_INVALID)
 		rate = rate_index;
@@ -152,40 +152,40 @@ static inline u8 iwl_get_prev_ieee_rate(
 }
 
 /**
- * iwl_fill_rs_info - Fill an output text buffer with the rate representation
+ * iwl3945_fill_rs_info - Fill an output text buffer with the rate representation
  *
  * NOTE:  This is provided as a quick mechanism for a user to visualize
  * the performance of the rate control alogirthm and is not meant to be
  * parsed software.
  */
-extern int iwl_fill_rs_info(struct ieee80211_hw *, char *buf, u8 sta_id);
+extern int iwl3945_fill_rs_info(struct ieee80211_hw *, char *buf, u8 sta_id);
 
 /**
- * iwl_rate_scale_init - Initialize the rate scale table based on assoc info
+ * iwl3945_rate_scale_init - Initialize the rate scale table based on assoc info
  *
  * The specific througput table used is based on the type of network
  * the associated with, including A, B, G, and G w/ TGG protection
  */
-extern void iwl_rate_scale_init(struct ieee80211_hw *hw, s32 sta_id);
+extern void iwl3945_rate_scale_init(struct ieee80211_hw *hw, s32 sta_id);
 
 /**
- * iwl_rate_control_register - Register the rate control algorithm callbacks
+ * iwl3945_rate_control_register - Register the rate control algorithm callbacks
  *
  * Since the rate control algorithm is hardware specific, there is no need
  * or reason to place it as a stand alone module.  The driver can call
- * iwl_rate_control_register in order to register the rate control callbacks
+ * iwl3945_rate_control_register in order to register the rate control callbacks
  * with the mac80211 subsystem.  This should be performed prior to calling
  * ieee80211_register_hw
  *
  */
-extern void iwl_rate_control_register(struct ieee80211_hw *hw);
+extern void iwl3945_rate_control_register(struct ieee80211_hw *hw);
 
 /**
- * iwl_rate_control_unregister - Unregister the rate control callbacks
+ * iwl3945_rate_control_unregister - Unregister the rate control callbacks
  *
  * This should be called after calling ieee80211_unregister_hw, but before
  * the driver is unloaded.
  */
-extern void iwl_rate_control_unregister(struct ieee80211_hw *hw);
+extern void iwl3945_rate_control_unregister(struct ieee80211_hw *hw);
 
 #endif
drivers/net/wireless/iwlwifi/iwl-3945.c +258 -258

1,170 lines not on this page · raw message

drivers/net/wireless/iwlwifi/iwl-3945.h +194 -194

388 lines not on this page · raw message

drivers/net/wireless/iwlwifi/iwl3945-base.c +1091 -1090

2,181 lines not on this page · raw message

drivers/net/wireless/iwlwifi/Kconfig +1 -5
Index: linux-2.6/drivers/net/wireless/iwlwifi/Kconfig
===================================================================

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Part of the diff is not shown here. View the raw message.

#1 lore raw
Quoted 6 lines · Christoph Hellwig

prefix all symbols with iwl3945_ and thus allow building the driver into the kernel. Also remove all the useless default statements in Kconfig while we're at it.

Did you do this manually or with a script? If it is the latter, can you run it again against my latest updates for the driver (30 patches I just sent to linux-wireless) or share the script with me?

Thanks,
-yi

#2 lore raw
Quoted 7 lines · Zhu Yi
Quoted 5 lines · Christoph Hellwig

prefix all symbols with iwl3945_ and thus allow building the driver into the kernel. Also remove all the useless default statements in Kconfig while we're at it.

Quoted 5 lines
Quoted 1 line

Did you do this manually or with a script? If it is the latter, can you run it again against my latest updates for the driver (30 patches I just sent to linux-wireless) or share the script with me?

Basically just %s/iwl_/iwl<whatever>_/ in vi, with a tiny bit of manual fixup. (one iwl_ function is actually coming from a still shared beader and the BROADCAST_ADDR IIRC)