Skip to contentSkip to conversation

drivers/pci, drivers/dma: kill unused vars

PATCH In review Jeff Garzik 2 participants 2 messages Oct 13, 2007 – Oct 15, 2007

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/pci, drivers/dma: kill unused vars

Kill two never-used (not even in hidden debug macros) variables, noticed by the compiler.

---
 drivers/dma/ioatdma.c                  |    1 -
 drivers/pci/hotplug/pci_hotplug_core.c |    2 --
 2 files changed, 3 deletions(-)
drivers/dma/ioatdma.c +0 -1
index 41b18c5..d9db64b 100644
@@ -244,7 +244,6 @@ static void ioat_dma_free_chan_resources(struct dma_chan *chan)
 	struct ioat_dma_chan *ioat_chan = to_ioat_chan(chan);
 	struct ioat_device *ioat_device = to_ioat_device(chan->device);
 	struct ioat_desc_sw *desc, *_desc;
-	u16 chanctrl;
 	int in_use_descs = 0;
 
 	ioat_dma_memcpy_cleanup(ioat_chan);
drivers/pci/hotplug/pci_hotplug_core.c +0 -2
index f0eba53..01c351c 100644
@@ -689,8 +689,6 @@ int pci_hp_deregister (struct hotplug_slot *slot)
 int __must_check pci_hp_change_slot_info(struct hotplug_slot *slot,
 					 struct hotplug_slot_info *info)
 {
-	int retval;
-
 	if ((slot == NULL) || (info == NULL))
 		return -ENODEV;
 
Acked-by on v1 1/1
#1 lore raw
Quoted 29 lines

-----Original Message-----
From: Jeff Garzik [mailto:[email protected]]
Sent: Saturday, October 13, 2007 12:07 PM
To: Andrew Morton; Linus Torvalds
Cc: LKML; Greg KH; Nelson, Shannon; Williams, Dan J
Subject: [PATCH] drivers/pci, drivers/dma: kill unused vars

Kill two never-used (not even in hidden debug macros) variables, noticed by the compiler.

---

drivers/dma/ioatdma.c                  |    1 -
drivers/pci/hotplug/pci_hotplug_core.c |    2 --
2 files changed, 3 deletions(-)
drivers/dma/ioatdma.c +0 -1
index 41b18c5..d9db64b 100644
@@ -244,7 +244,6 @@ static void 
 ioat_dma_free_chan_resources(struct dma_chan *chan)
 	struct ioat_dma_chan *ioat_chan = to_ioat_chan(chan);
 	struct ioat_device *ioat_device = to_ioat_device(chan->device);
 	struct ioat_desc_sw *desc, *_desc;
-	u16 chanctrl;
 	int in_use_descs = 0;
 
Quoted 1 line
	ioat_dma_memcpy_cleanup(ioat_chan);

FYI - this code gets heavily revised by ioat patches in -mm that Andrew is planning on merging soon.

sln

Quoted 15 lines
drivers/pci/hotplug/pci_hotplug_core.c +0 -2
index f0eba53..01c351c 100644
@@ -689,8 +689,6 @@ int pci_hp_deregister (struct hotplug_slot *slot)
 int __must_check pci_hp_change_slot_info(struct hotplug_slot *slot,
 					 struct hotplug_slot_info *info)
 {
-	int retval;
-
 	if ((slot == NULL) || (info == NULL))
 		return -ENODEV;