skb->tail in ibm_newemac should be skb_tail_pointer()

PATCH New Al Viro 1 participant 1 message Oct 14, 2007 Network drivers

lore

Share & tools

lore

Al Viro

author

2007-10-14 18:20 UTC #0 lore raw

PATCH 1/1 skb->tail in ibm_newemac should be skb_tail_pointer()

... since that sucker is not 32bit-only and on 64bit skb->tail is an offset, not a pointer.

Signed-off-by Al Viro <[email protected]>

---
 drivers/net/ibm_newemac/core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/net/ibm_newemac/core.c +1 -1

index 8ea5009..7a5aabd 100644
@@ -1534,7 +1534,7 @@ static inline int emac_rx_sg_append(struct emac_instance *dev, int slot)
 			dev_kfree_skb(dev->rx_sg_skb);
 			dev->rx_sg_skb = NULL;
 		} else {
-			cacheable_memcpy(dev->rx_sg_skb->tail,
+			cacheable_memcpy(skb_tail_pointer(dev->rx_sg_skb),
 					 dev->rx_skb[slot]->data, len);
 			skb_put(dev->rx_sg_skb, len);
 			emac_recycle_rx_skb(dev, slot, len);

Signature · 1 line

1.5.3.GIT