Skip to contentSkip to conversation

ssb: fix build failure

PATCH In review Michael Buesch 3 participants 4 messages Oct 15, 2007 Sonics silicon backplane driver (ssb)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ssb: fix build failure

From: Ingo Molnar <[email protected]>

fix build failure if PCMCIA=m but SSB=y:

drivers/built-in.o: In function `ssb_pcmcia_switch_coreidx':
: undefined reference to `pcmcia_access_configuration_register'

(fix symmetric bug for PCI too.)

---
 drivers/ssb/Kconfig |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/ssb/Kconfig +2 -2
Index: linux/drivers/ssb/Kconfig
===================================================================
@@ -22,7 +22,7 @@ config SSB
 
 config SSB_PCIHOST_POSSIBLE
 	bool
-	depends on SSB && PCI
+	depends on SSB && (PCI = SSB)
 	default y
 
 config SSB_PCIHOST
@@ -37,7 +37,7 @@ config SSB_PCIHOST
 
 config SSB_PCMCIAHOST_POSSIBLE
 	bool
-	depends on SSB && PCMCIA && EXPERIMENTAL
+	depends on SSB && (PCMCIA = SSB) && EXPERIMENTAL
 	default y
 
 config SSB_PCMCIAHOST

-------------------------------------------------------

Signature · 1 line
Greetings Michael.
#1 lore raw
Quoted 30 lines · On Mon, 15 Oct 2007 16:23:04 +0200 Michael Buesch wrote:

From: Ingo Molnar <[email protected]>

fix build failure if PCMCIA=m but SSB=y:

drivers/built-in.o: In function `ssb_pcmcia_switch_coreidx':
: undefined reference to `pcmcia_access_configuration_register'

(fix symmetric bug for PCI too.)

---
 drivers/ssb/Kconfig |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux/drivers/ssb/Kconfig
===================================================================

drivers/ssb/Kconfig +1 -1
@@ -22,7 +22,7 @@ config SSB
 
 config SSB_PCIHOST_POSSIBLE
 	bool
-	depends on SSB && PCI
+	depends on SSB && (PCI = SSB)
 	default y
 
 config SSB_PCIHOST

drivers/ssb/Kconfig config SSB_PCIHOST · line 43

Quoted 8 lines
drivers/ssb/Kconfig +1 -1
@@ -37,7 +37,7 @@ config SSB_PCIHOST
 
 config SSB_PCMCIAHOST_POSSIBLE
 	bool
-	depends on SSB && PCMCIA && EXPERIMENTAL
+	depends on SSB && (PCMCIA = SSB) && EXPERIMENTAL
 	default y
 
 config SSB_PCMCIAHOST

That's usually done more like this:

	depends on SSB && (PCMCIA = y || PCMCIA = SSB) && EXPERIMENTAL

This allows PCMCIA to be y or m, but if PCMCIA is m, then SSB is restricted to m as well (or n).
I.e., PCMCIA = SSB is too strict and not required.

or am I not seeing straight?

---
~Randy

#2 lore raw
Quoted 7 lines · Randy Dunlap

That's usually done more like this:

	depends on SSB && (PCMCIA = y || PCMCIA = SSB) && EXPERIMENTAL

This allows PCMCIA to be y or m, but if PCMCIA is m, then SSB is restricted to m as well (or n). I.e., PCMCIA = SSB is too strict and not required.

indeed - updated patch below.

Ingo

------------------>
From: Ingo Molnar <[email protected]>

fix build failure if PCMCIA=m but SSB=y:

drivers/built-in.o: In function `ssb_pcmcia_switch_coreidx':
: undefined reference to `pcmcia_access_configuration_register'

(fix symmetric bug for PCI too.)

---
 drivers/ssb/Kconfig |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/ssb/Kconfig +2 -2
Index: linux/drivers/ssb/Kconfig
===================================================================
@@ -22,7 +22,7 @@ config SSB
 
 config SSB_PCIHOST_POSSIBLE
 	bool
-	depends on SSB && PCI
+	depends on SSB && (PCI = y || PCI = SSB)
 	default y
 
 config SSB_PCIHOST
@@ -37,7 +37,7 @@ config SSB_PCIHOST
 
 config SSB_PCMCIAHOST_POSSIBLE
 	bool
-	depends on SSB && PCMCIA && EXPERIMENTAL
+	depends on SSB && (PCMCIA = y || PCMCIA = SSB) && EXPERIMENTAL
 	default y
 
 config SSB_PCMCIAHOST
Acked-by
#3 lore raw
Quoted 11 lines · Ingo Molnar
Quoted 5 lines · Randy Dunlap

That's usually done more like this:

	depends on SSB && (PCMCIA = y || PCMCIA = SSB) && EXPERIMENTAL

This allows PCMCIA to be y or m, but if PCMCIA is m, then SSB is restricted to m as well (or n). I.e., PCMCIA = SSB is too strict and not required.

indeed - updated patch below.

Ingo

Quoted 40 lines

------------------>
From: Ingo Molnar <[email protected]>

fix build failure if PCMCIA=m but SSB=y:

drivers/built-in.o: In function `ssb_pcmcia_switch_coreidx':
: undefined reference to `pcmcia_access_configuration_register'

(fix symmetric bug for PCI too.)

---
 drivers/ssb/Kconfig |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux/drivers/ssb/Kconfig
===================================================================

drivers/ssb/Kconfig +2 -2
@@ -22,7 +22,7 @@ config SSB
 
 config SSB_PCIHOST_POSSIBLE
 	bool
-	depends on SSB && PCI
+	depends on SSB && (PCI = y || PCI = SSB)
 	default y
 
 config SSB_PCIHOST
@@ -37,7 +37,7 @@ config SSB_PCIHOST
 
 config SSB_PCMCIAHOST_POSSIBLE
 	bool
-	depends on SSB && PCMCIA && EXPERIMENTAL
+	depends on SSB && (PCMCIA = y || PCMCIA = SSB) && EXPERIMENTAL
 	default y
 
 config SSB_PCMCIAHOST
Signature · 1 line
~Randy