Skip to contentSkip to conversation

pfkey: sending an SADB_GET responds with an SADB_GET

PATCH In review Charles Hardin 2 participants 2 messages Oct 17, 2007 – Oct 18, 2007

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pfkey: sending an SADB_GET responds with an SADB_GET

Kernel needs to respond to an SADB_GET with the same message type to conform to the RFC 2367 Section 3.1.5

net/key/af_key.c +0 -0
index 7969f8a..fb4fee1 100644
@@ -1552,7 +1552,7 @@ static int pfkey_get(struct sock *sk, struct sk_buff

*skb,

        out_hdr = (struct sadb_msg *) out_skb->data;
        out_hdr->sadb_msg_version = hdr->sadb_msg_version;
-       out_hdr->sadb_msg_type = SADB_DUMP;
+       out_hdr->sadb_msg_type = SADB_GET;
        out_hdr->sadb_msg_satype = pfkey_proto2satype(proto);
        out_hdr->sadb_msg_errno = 0;
        out_hdr->sadb_msg_reserved = 0;
maintainer
#1 lore raw

From: Charles Hardin <[email protected]>
Date: Wed, 17 Oct 2007 14:36:10 -0700

Quoted 2 lines

Kernel needs to respond to an SADB_GET with the same message type to conform to the RFC 2367 Section 3.1.5

I can't apply this:

1) We need you to provide an appropriate Signed-off-by: line in the changelog of your patch.

2) Your email client corrupted the patch, changing tabs into spaces, and adding newline breaks to long lines.

Please resubmit with these two errors corrected, thank you.