missing include in mmc
Subsystems (2)
PATCH 1/1 missing include in mmc
AFAICS, fallout from repacing include of blkdev.h with include of bio.h.
---
drivers/mmc/host/mmc_spi.c +1 -0
@@ -30,6 +30,7 @@#include <linux/dma-mapping.h> #include <linux/crc7.h> #include <linux/crc-itu-t.h> +#include <linux/scatterlist.h> #include <linux/mmc/host.h> #include <linux/mmc/mmc.h> /* for R1_SPI_* bit values */
Quoted 8 lines
From [email protected] Tue Oct 16 17:18:43 2007
Date: Wed, 17 Oct 2007 01:09:07 +0100
From: Al Viro <[email protected]>
To: Linus Torvalds <[email protected]>
Cc: [email protected], [email protected]
Subject: [PATCH] missing include in mmcAFAICS, fallout from repacing include of
blkdev.hwith include ofbio.h.
Out of curiousity, which architecture(s) need this?
I did test builds on three, and didn't see a need for it ...
Quoted 15 lines
Signed-off-by Al Viro <[email protected]>---
drivers/mmc/host/mmc_spi.c +1
-0@@ -30,6 +30,7 @@#include <linux/dma-mapping.h> #include <linux/crc7.h> #include <linux/crc-itu-t.h> +#include <linux/scatterlist.h> #include <linux/mmc/host.h> #include <linux/mmc/mmc.h> /* for R1_SPI_* bit values */
Quoted 10 lines · David Brownell
Quoted 8 lines
From [email protected] Tue Oct 16 17:18:43 2007
Date: Wed, 17 Oct 2007 01:09:07 +0100
From: Al Viro <[email protected]>
To: Linus Torvalds <[email protected]>
Cc: [email protected], [email protected]
Subject: [PATCH] missing include in mmcAFAICS, fallout from repacing include of
blkdev.hwith include ofbio.h.Out of curiousity, which architecture(s) need this?
Umm... IIRC, m32r had been the first build to step into that, at which point
the missing include had been added; the rest had reached that point later, so I'm not sure which ones would trigger the same crap. Not hard to test, though...
Aha. m68k as well.
Quoted 10 lines
Quoted 3 lines
Quoted 1 line
AFAICS, fallout from repacing include of
blkdev.hwith include ofbio.h.Out of curiousity, which architecture(s) need this?
Umm... IIRC, m32r had been the first build to step into that, at which point
the missing include had been added; the rest had reached that point later, so I'm not sure which ones would trigger the same crap. Not hard to test, though...Aha. m68k as well.
FWIW this driver originally started out on ColdFire (m68k derived), a few years back. :)
Every time I seee a case where architectures don't act the same with respect to #includes, I count it as an unpleasant surprise. Not one that's very easy to avoid, unfortunately, but I think it's been happening less often lately.
Thanks for the fix.
- Dave
Quoted 10 lines · David Brownell
Quoted 10 lines
Quoted 3 lines
Quoted 1 line
AFAICS, fallout from repacing include of
blkdev.hwith include ofbio.h.Out of curiousity, which architecture(s) need this?
Umm... IIRC, m32r had been the first build to step into that, at which point
the missing include had been added; the rest had reached that point later, so I'm not sure which ones would trigger the same crap. Not hard to test, though...Aha. m68k as well.
Yesterday I saw a similar issue with drivers/md/dm-mpath-rdac.c, but it disappeared during the night, and I didn't see an obvious change that fixed it...
Quoted 4 lines
Every time I seee a case where architectures don't act the same with respect to #includes, I count it as an unpleasant surprise. Not one that's very easy to avoid, unfortunately, but I think it's been happening less often lately.
Simple rule of thumb: he who uses fields of struct xxx should include the header file that defines struct xxx...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds