Skip to contentSkip to conversation

Fix vmemmap warning in init_64..c

PATCH In review Tony Breeds 2 participants 2 messages Oct 17, 2007 PowerPC

lore
Share & tools
lore

Tony Breeds

author
#0 lore raw

PATCH 1/1 Fix vmemmap warning in init_64..c

Use the right printk format to silence the following warning.

CC arch/powerpc/mm/init_64.o
arch/powerpc/mm/init_64.c: In function 'vmemmap_populate':
arch/powerpc/mm/init_64.c:243: warning: format '%p' expects type 'void *', but argument 4 has type 'long unsigned int'

Signed-off-by Tony Breeds <[email protected]>

---

Also a whitespace fix while I'm there.

 arch/powerpc/mm/init_64.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/powerpc/mm/init_64.c +1 -1
index 702d884..6720b1c 100644
@@ -240,7 +240,7 @@ int __meminit vmemmap_populate(struct page *start_page,
 			return -ENOMEM;
 
 		printk(KERN_WARNING "vmemmap %08lx allocated at %p, "
-					"physical %p.\n", start, p, __pa(p));
+		                    "physical %08lx.\n", start, p, __pa(p));
 
 		mapped = htab_bolt_mapping(start, start + page_size,
 					__pa(p), mode_rw, mmu_linear_psize,
Signature · 6 lines
1.5.3.4

Yours Tony

  linux.conf.au        http://linux.conf.au/ || http://lca2008.linux.org.au/
  Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!
#1 lore raw
Quoted 19 lines · Tony Breeds

Use the right printk format to silence the following warning.

CC arch/powerpc/mm/init_64.o
arch/powerpc/mm/init_64.c: In function 'vmemmap_populate':
arch/powerpc/mm/init_64.c:243: warning: format '%p' expects type 'void *', but argument 4 has type 'long unsigned int'

Signed-off-by Tony Breeds <[email protected]>

---

Also a whitespace fix while I'm there.

 arch/powerpc/mm/init_64.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/powerpc/mm/init_64.c +0 -0
index 702d884..6720b1c 100644

arch/powerpc/mm/init_64.c int __meminit vmemmap_populate(struct page *start_page, · line 242

Quoted 3 lines
arch/powerpc/mm/init_64.c +0 -0
@@ -240,7 +240,7 @@ int __meminit vmemmap_populate(struct page *start_page,
 			return -ENOMEM;
 
 		printk(KERN_WARNING "vmemmap %08lx allocated at %p, "

                                              ^^

arch/powerpc/mm/init_64.c int __meminit vmemmap_populate(struct page *start_page, · line 243

Quoted 2 lines
arch/powerpc/mm/init_64.c +1 -1
-					"physical %p.\n", start, p, __pa(p));
+		                    "physical %08lx.\n", start, p, __pa(p));

                                               ^^

Anyone with memory outside 32-bit (`%08lx') space?

With kind regards,

Geert Uytterhoeven
Software Architect

Sony Network and Software Technology Center Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium

Phone:    +32 (0)2 700 8453	
Fax:      +32 (0)2 700 8622	
E-mail:   [email protected]	
Internet: http://www.sony-europe.com/

Sony Network and Software Technology Center Europe
A division of Sony Service Centre (Europe) N.V. Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium VAT BE 0413.825.160 · RPR Brussels
Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619