Skip to contentSkip to conversation

reduce frequency of cursor blinking

PATCH Dave Jones 2 participants 3 messages Oct 16, 2007 – Oct 17, 2007

Subsystems (2)
lore
Share & tools
lore

Dave Jones

author
#0 lore raw

Depending on CONFIG_HZ, we blink the cursor at 20,50,60 or 200Hz. Even if it only blinks once per 1000Hz, there's no visible difference.

drivers/video/console/fbcon.c +1 -1
index 73813c6..7d9bae5 100644
@@ -433,7 +433,7 @@ static void cursor_timer_handler(unsigned long dev_addr)
 	struct fbcon_ops *ops = info->fbcon_par;
 
 	schedule_work(&info->queue);
-	mod_timer(&ops->cursor_timer, jiffies + HZ/5);
+	mod_timer(&ops->cursor_timer, jiffies + HZ);
 }
 
 static void fbcon_add_cursor_timer(struct fb_info *info)
Signature · 1 line
http://www.codemonkey.org.uk
#1 lore raw
Quoted 1 line · On Tue, 16 Oct 2007 14:19:11 -0400 Dave Jones <[email protected]> wrote:

Depending on CONFIG_HZ, we blink the cursor at 20,50,60 or 200Hz.

eh no, that's 5 times per second ...

Quoted 1 line
drivers/video/console/fbcon.c +0 -1
-	mod_timer(&ops->cursor_timer, jiffies + HZ/5);
author
#2 lore raw
Quoted 6 lines · Arjan van de Ven
Quoted 1 line · On Tue, 16 Oct 2007 14:19:11 -0400 Dave Jones <[email protected]> wrote:

Depending on CONFIG_HZ, we blink the cursor at 20,50,60 or 200Hz.

eh no, that's 5 times per second ...

Indeed. Still seems excessive though.
How about twice per second ?

drivers/video/console/fbcon.c +1 -1
index 73813c6..7d9bae5 100644
@@ -433,7 +433,7 @@ static void cursor_timer_handler(unsigned long dev_addr)
 	struct fbcon_ops *ops = info->fbcon_par;
 
 	schedule_work(&info->queue);
-	mod_timer(&ops->cursor_timer, jiffies + HZ/5);
+	mod_timer(&ops->cursor_timer, jiffies + HZ/2);
 }
 
 static void fbcon_add_cursor_timer(struct fb_info *info)
Signature · 1 line
http://www.codemonkey.org.uk