Skip to contentSkip to conversation

Fix up tag usage in lpfc

PATCH In review Hannes Reinecke 2 participants 2 messages Oct 18, 2007 – Oct 19, 2007

Subsystems (2)
SCSI Emulex/Broadcom lpfc FC/FCoE SCSI driver
lore
Share & tools
lore

Hannes Reinecke

author
#0 lore raw

PATCH 1/1 Fix up tag usage in lpfc

Hi James,

appearently the lpfc driver is sligtly confused about the meaning of the 'scmd->tag' value. It should rather inspect the correct flags to detect the proper SCSI Tag value.

Cheers,

Hannes

Signature · 4 lines
Dr. Hannes Reinecke		      zSeries & Storage
[email protected]			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N�rnberg
GF: Markus Rex, HRB 16746 (AG N�rnberg)
drivers/scsi/lpfc/lpfc_scsi.c +2 -9
index cd67493..a1cf99a 100644
@@ -693,17 +693,10 @@ lpfc_scsi_prep_cmnd(struct lpfc_vport *vport, struct lpfc_scsi_buf *lpfc_cmd,
 	memcpy(&fcp_cmnd->fcpCdb[0], scsi_cmnd->cmnd, 16);
 
 	if (scsi_cmnd->device->tagged_supported) {
-		switch (scsi_cmnd->tag) {
-		case HEAD_OF_QUEUE_TAG:
-			fcp_cmnd->fcpCntl1 = HEAD_OF_Q;
-			break;
-		case ORDERED_QUEUE_TAG:
+		if (scsi_cmnd->device->ordered_tags)
 			fcp_cmnd->fcpCntl1 = ORDERED_Q;
-			break;
-		default:
+		else
 			fcp_cmnd->fcpCntl1 = SIMPLE_Q;
-			break;
-		}
 	} else
 		fcp_cmnd->fcpCntl1 = 0;
#1 lore raw

Yep, this was an oversight... In looking through it though, there are some additional things that should be checked. We're about to post our next set of patches, so I'll include this fix with them.

thanks.

-- james s

Quoted 10 lines · Hannes Reinecke

Hi James,

appearently the lpfc driver is sligtly confused about the meaning of the 'scmd->tag' value. It should rather inspect the correct flags to detect the proper SCSI Tag value.

Cheers,

Hannes