Skip to contentSkip to conversation

add flags for conditional compilation of qemu dependencies

PATCH Applied Carlo Marcelo Arenas Belon 2 participants 5 messages Oct 17, 2007 – Oct 18, 2007 1 message not in the archive KVM

lore
Share & tools
lore

Carlo Marcelo Arenas Belon

author
#0 lore raw

cover add flags for conditional compilation of qemu dependencies

This series adds options to kvm's configure that match the ones used by qemu to conditionally enable or disable options that alter its runtime dependencies and functionality, like for example, support for alsa or TLS encrypted vnc sessions.

Carlo

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/

author
#1 lore raw

PATCH 1/2 alsa configure option

Add an --enable-alsa option to conditionally add support for alsa so that QEMU_AUDIO_DRV=alsa is supported.

This makes the dependency to alsa conditional and explicit.

Signed-off-by Carlo Marcelo Arenas Belon <[email protected]>
---
 configure |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)
configure +6 -1
index d9292fe..8c6d340 100755
@@ -4,6 +4,7 @@ prefix=/usr/local
 kerneldir=/lib/modules/$(uname -r)/build
 want_module=1
 qemu_cc=$(ls /usr/bin/gcc3* /usr/bin/gcc-3* 2>/dev/null | tail -n1)
+enable_alsa=
 disable_gcc_check=
 
 usage() {

@@ -16,6 +17,7 @@ usage() {
 	    --with-patched-kernel  don't use external module
 	    --kerneldir=DIR        kernel build directory ($kerneldir)
 	    --qemu-cc="$qemu_cc"   compiler for qemu (needs gcc3.x) ($qemu_cc)
+	    --enable-alsa          enable alsa support for qemu
 	    --disable-gcc-check    don't insist on gcc-3.x
                                    - this will break running without kvm
 EOF

@@ -50,6 +52,9 @@ while [[ "$1" = -* ]]; do
 	--qemu-cc)
 	    qemu_cc="$arg"
 	    ;;
+	--enable-alsa)
+	    enable_alsa=1
+	    ;;
 	--disable-gcc-check)
 	    disable_gcc_check=1
 	    ;;

@@ -85,7 +90,7 @@ target_cpu() {
     --disable-kqemu --extra-cflags="-I $PWD/../user" \
     --extra-ldflags="-L $PWD/../user" \
     --enable-kvm --kernel-path="$libkvm_kerneldir" \
-    --enable-alsa \
+    ${enable_alsa:+"--enable-alsa"} \
     ${disable_gcc_check:+"--disable-gcc-check"} \
     --prefix="$prefix"
 )
Signature · 8 lines
1.5.2.5


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
author
#2 lore raw

PATCH 2/2 vnc-tls configure flag

In reply to Carlo Marcelo Arenas Belon

Add a --disable-vnc-tls option so that support for TLS authentication for the VNC server can be conditionally disabled.

This makes the dependency to gnutls added by the new qemu conditional and explicit.

Signed-off-by Carlo Marcelo Arenas Belon <[email protected]>
---
 configure |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
configure +6 -0
index 8c6d340..f054d12 100755
@@ -5,6 +5,7 @@ kerneldir=/lib/modules/$(uname -r)/build
 want_module=1
 qemu_cc=$(ls /usr/bin/gcc3* /usr/bin/gcc-3* 2>/dev/null | tail -n1)
 enable_alsa=
+disable_vnc_tls=
 disable_gcc_check=
 
 usage() {

@@ -18,6 +19,7 @@ usage() {
 	    --kerneldir=DIR        kernel build directory ($kerneldir)
 	    --qemu-cc="$qemu_cc"   compiler for qemu (needs gcc3.x) ($qemu_cc)
 	    --enable-alsa          enable alsa support for qemu
+	    --disable-vnc-tls      disable vnc tls support for qemu
 	    --disable-gcc-check    don't insist on gcc-3.x
                                    - this will break running without kvm
 EOF

@@ -55,6 +57,9 @@ while [[ "$1" = -* ]]; do
 	--enable-alsa)
 	    enable_alsa=1
 	    ;;
+	--disable-vnc-tls)
+	    disable_vnc_tls=1
+	    ;;
 	--disable-gcc-check)
 	    disable_gcc_check=1
 	    ;;

@@ -91,6 +96,7 @@ target_cpu() {
     --extra-ldflags="-L $PWD/../user" \
     --enable-kvm --kernel-path="$libkvm_kerneldir" \
     ${enable_alsa:+"--enable-alsa"} \
+    ${disable_vnc_tls:+"--disable-vnc-tls"} \
     ${disable_gcc_check:+"--disable-gcc-check"} \
     --prefix="$prefix"
 )
Signature · 8 lines
1.5.2.5


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
Applied
#3 lore raw
In reply to Carlo Marcelo Arenas Belon
Quoted 6 lines · Carlo Marcelo Arenas Belon

This series adds options to kvm's configure that match the ones used by qemu to conditionally enable or disable options that alter its runtime dependencies and functionality, like for example, support for alsa or TLS encrypted vnc sessions.

Applied both, thanks. But if someone is thinking of a patch flood to add all qemu options, I'd prefer a passthrough instead.

Signature · 8 lines
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

A message that is not in the archive (sent off-list or not yet received): 47163E66.5010501-atKUWr5tajBWk0Htik3J/[email protected]

author
#5 lore raw
Quoted 8 lines · Avi Kivity
Quoted 4 lines · Carlo Marcelo Arenas Belon

This series adds options to kvm's configure that match the ones used by qemu to conditionally enable or disable options that alter its runtime dependencies and functionality, like for example, support for alsa or TLS encrypted vnc sessions.

Applied both, thanks. But if someone is thinking of a patch flood to add all qemu options, I'd prefer a passthrough instead.

The only other option I was interested in implementing was the one to conditionally enable or disable support for sdl, but I can see why a passthrough is a better option in the long run.

Carlo

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/