Skip to contentSkip to conversation

ide/pci/sis5513.c: add missing "else"

PATCH Applied Adrian Bunk 2 participants 2 messages Oct 19, 2007 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ide/pci/sis5513.c: add missing "else"

This patch adds a missing "else" that was missing in commit c77a89cd98d99819f23a4a08e5e17ee1f13f6e4d.

Spotted by the Coverity checker.

---
2e4b8d4f58ea45e55c87ba5563b0d0e135cac2b4

drivers/ide/pci/sis5513.c +1 -1
index c1d280b..1680926 100644
@@ -264,7 +264,7 @@ static void sis_ata133_program_timings(ide_drive_t *drive, const u8 mode)
 	if (mode >= XFER_MW_DMA_0) {
 		t1 &= ~0x04;	/* disable UDMA */
 		idx = mode - XFER_MW_DMA_0 + 5;
-	}
+	} else
 		idx = mode - XFER_PIO_0;
 	t1 |= ini_time_value[clk][idx] << 12;
 	t1 |= act_time_value[clk][idx] << 16;
#1 lore raw
Quoted 6 lines · Adrian Bunk

This patch adds a missing "else" that was missing in commit c77a89cd98d99819f23a4a08e5e17ee1f13f6e4d.

Spotted by the Coverity checker.

applied, thanks!

Quoted 15 lines

---
2e4b8d4f58ea45e55c87ba5563b0d0e135cac2b4

drivers/ide/pci/sis5513.c +1 -1
index c1d280b..1680926 100644
@@ -264,7 +264,7 @@ static void sis_ata133_program_timings(ide_drive_t *drive, const u8 mode)
 	if (mode >= XFER_MW_DMA_0) {
 		t1 &= ~0x04;	/* disable UDMA */
 		idx = mode - XFER_MW_DMA_0 + 5;
-	}
+	} else
 		idx = mode - XFER_PIO_0;
 	t1 |= ini_time_value[clk][idx] << 12;
 	t1 |= act_time_value[clk][idx] << 16;