Skip to contentSkip to conversation

tg3: MII => TP

PATCH Applied Matt Carlson 6 participants 7 messages Oct 19, 2007 – Oct 22, 2007

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Matt Carlson

author
#0 lore raw

PATCH 2/7 tg3: MII => TP

This patch changes the PHY type reported through ethtool for copper devices from MII to TP. The latter is more accurate.

Signed-off-by Matt Carlson <[email protected]>
Signed-off-by Michael Chan <[email protected]>
drivers/net/tg3.c +1 -1
index 253d761..66682b8 100644
@@ -8274,7 +8274,7 @@ static int tg3_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 				  SUPPORTED_100baseT_Full |
 				  SUPPORTED_10baseT_Half |
 				  SUPPORTED_10baseT_Full |
-				  SUPPORTED_MII);
+				  SUPPORTED_TP);
 		cmd->port = PORT_TP;
 	} else {
 		cmd->supported |= SUPPORTED_FIBRE;
#1 lore raw

linux kernel networking code review request

Hello,

I would like to get a review on some new Linux kernel networking code. The code is based on the 2.6.23 source tree and touches three files - two in ./net/ipv6 and one in ./include/net. What is the proper procedure for requesting a review?

Thanks - Fred
[email protected]

#2 lore raw

Re: linux kernel networking code review request

Quoted 8 lines · Fred L

Hello,

I would like to get a review on some new Linux kernel networking code. The code is based on the 2.6.23 source tree and touches three files - two in ./net/ipv6 and one in ./include/net. What is the proper procedure for requesting a review?

Just don your flameproof pants and post the changes here ;)

Signature · 1 line
Dmitry
#3 lore raw

Re: linux kernel networking code review request

Quoted 11 lines · Dmitry Torokhov
Quoted 8 lines · Fred L

Hello,

I would like to get a review on some new Linux kernel networking code. The code is based on the 2.6.23 source tree and touches three files - two in ./net/ipv6 and one in ./include/net. What is the proper procedure for requesting a review?

Just don your flameproof pants and post the changes here ;)

In addition, check what is being said in Documentation/SubmittingPatches

:-)

Signature · 1 line
 i.
#5 lore raw
Quoted 13 lines · David Miller

From: "Matt Carlson" <[email protected]>
Date: Fri, 19 Oct 2007 14:36:42 -0700

Quoted 5 lines

This patch changes the PHY type reported through ethtool for copper devices from MII to TP. The latter is more accurate.

Signed-off-by Matt Carlson <[email protected]>
Signed-off-by Michael Chan <[email protected]>

You should set both MII and TP, since these copper interfaces have a MII based twisted-pair physical layer.

MII in this ethtool context means an MII connector on the card that can connect to an external transceiver, right?

Or does it mean internal MII interface to the PHY?

maintainer
#6 lore raw

From: "Michael Chan" <[email protected]>
Date: Sun, 21 Oct 2007 20:49:25 -0700

Quoted 4 lines

MII in this ethtool context means an MII connector on the card that can connect to an external transceiver, right?

Or does it mean internal MII interface to the PHY?

Good question. Looking at drivers it's set randomly.

Probably you are right and it's supposed to mean you can specify PORT_MII in ethtool_cmd->port to select the external MII connector.

Please resubmit this change after the PCI error recovery issues are resolved.

Thanks.