kbuild: kconfig source with " " or not
Sam,
in Kconfig, most of source to include other kconfig has "..."
for example:
in arch/x86_64/Kconfig:
source "net/Kconfig"
but some other don't
< ./drivers/w1/Kconfig:source drivers/w1/masters/Kconfig < ./drivers/w1/Kconfig:source drivers/w1/slaves/Kconfig < ./drivers/i2c/Kconfig:source drivers/i2c/algos/Kconfig < ./drivers/i2c/Kconfig:source drivers/i2c/busses/Kconfig < ./drivers/i2c/Kconfig:source drivers/i2c/chips/Kconfig < ./arch/frv/Kconfig:source kernel/power/Kconfig
< ./arch/v850/Kconfig:source init/Kconfig
< ./arch/v850/Kconfig:source drivers/mtd/Kconfig
< ./arch/v850/Kconfig:source drivers/parport/Kconfig < ./arch/v850/Kconfig:#source drivers/pnp/Kconfig
< ./arch/v850/Kconfig:source drivers/block/Kconfig
< ./arch/v850/Kconfig:#source drivers/misc/Config.in < ./arch/ia64/Kconfig:source kernel/Kconfig.hz
< ./arch/i386/Kconfig:source kernel/Kconfig.hz
< ./arch/i386/Kconfig:source kernel/power/Kconfig
< ./arch/ppc/Kconfig:source arch/ppc/platforms/4xx/Kconfig < ./arch/ppc/Kconfig:source arch/ppc/platforms/85xx/Kconfig < ./arch/ppc/Kconfig:source kernel/Kconfig.hz
< ./arch/ppc/Kconfig:source kernel/Kconfig.preempt
< ./arch/ppc/Kconfig:source kernel/power/Kconfig
< ./arch/x86_64/Kconfig:source kernel/Kconfig.hz
< ./arch/x86_64/Kconfig:source kernel/power/Kconfig
< ./arch/x86_64/Kconfig:source drivers/Kconfig
< ./arch/x86_64/Kconfig:source fs/Kconfig
< ./arch/s390/Kconfig:source kernel/Kconfig.hz
< ./arch/cris/Kconfig:source mm/Kconfig
< ./arch/cris/Kconfig:source arch/cris/arch-v10/Kconfig < ./arch/cris/Kconfig:source arch/cris/arch-v10/drivers/Kconfig < ./arch/cris/Kconfig:#source drivers/misc/Config.in < ./arch/powerpc/Kconfig:source kernel/time/Kconfig
< ./arch/powerpc/Kconfig:source kernel/Kconfig.hz
< ./arch/powerpc/Kconfig:source kernel/Kconfig.preempt < ./arch/powerpc/Kconfig:source kernel/power/Kconfig < ./arch/sh64/Kconfig:source init/Kconfig
< ./arch/sh/Kconfig:source kernel/Kconfig.hz
< ./arch/sh/Kconfig:source kernel/power/Kconfig
< ./arch/sparc64/Kconfig:source kernel/Kconfig.hz
< ./arch/arm/Kconfig:source arch/arm/mm/Kconfig
< ./arch/blackfin/Kconfig:source kernel/Kconfig.hz
< ./block/Kconfig:source block/Kconfig.iosched
< ./security/Kconfig:source security/selinux/Kconfig
better to keep them consistent
YH
Hi Yinghai.
Quoted 53 lines · Yinghai Lu
Sam,
in
Kconfig, most of source to include other kconfig has "..."for example:
in
arch/x86_64/Kconfig:
source "net/Kconfig"but some other don't
< ./drivers/w1/Kconfig:source
drivers/w1/masters/Kconfig< ./drivers/w1/Kconfig:sourcedrivers/w1/slaves/Kconfig< ./drivers/i2c/Kconfig:sourcedrivers/i2c/algos/Kconfig< ./drivers/i2c/Kconfig:sourcedrivers/i2c/busses/Kconfig< ./drivers/i2c/Kconfig:sourcedrivers/i2c/chips/Kconfig< ./arch/frv/Kconfig:sourcekernel/power/Kconfig
< ./arch/v850/Kconfig:source init/Kconfig
< ./arch/v850/Kconfig:sourcedrivers/mtd/Kconfig
< ./arch/v850/Kconfig:sourcedrivers/parport/Kconfig< ./arch/v850/Kconfig:#sourcedrivers/pnp/Kconfig
< ./arch/v850/Kconfig:sourcedrivers/block/Kconfig
< ./arch/v850/Kconfig:#sourcedrivers/misc/Config.in< ./arch/ia64/Kconfig:sourcekernel/Kconfig.hz
< ./arch/i386/Kconfig:sourcekernel/Kconfig.hz
< ./arch/i386/Kconfig:sourcekernel/power/Kconfig
< ./arch/ppc/Kconfig:sourcearch/ppc/platforms/4xx/Kconfig< ./arch/ppc/Kconfig:sourcearch/ppc/platforms/85xx/Kconfig< ./arch/ppc/Kconfig:sourcekernel/Kconfig.hz
< ./arch/ppc/Kconfig:sourcekernel/Kconfig.preempt
< ./arch/ppc/Kconfig:sourcekernel/power/Kconfig
< ./arch/x86_64/Kconfig:sourcekernel/Kconfig.hz
< ./arch/x86_64/Kconfig:sourcekernel/power/Kconfig
< ./arch/x86_64/Kconfig:sourcedrivers/Kconfig
< ./arch/x86_64/Kconfig:source fs/Kconfig
< ./arch/s390/Kconfig:sourcekernel/Kconfig.hz
< ./arch/cris/Kconfig:source mm/Kconfig
< ./arch/cris/Kconfig:sourcearch/cris/arch-v10/Kconfig< ./arch/cris/Kconfig:sourcearch/cris/arch-v10/drivers/Kconfig< ./arch/cris/Kconfig:#sourcedrivers/misc/Config.in< ./arch/powerpc/Kconfig:sourcekernel/time/Kconfig
< ./arch/powerpc/Kconfig:sourcekernel/Kconfig.hz
< ./arch/powerpc/Kconfig:sourcekernel/Kconfig.preempt< ./arch/powerpc/Kconfig:sourcekernel/power/Kconfig< ./arch/sh64/Kconfig:source init/Kconfig
< ./arch/sh/Kconfig:sourcekernel/Kconfig.hz
< ./arch/sh/Kconfig:sourcekernel/power/Kconfig
< ./arch/sparc64/Kconfig:sourcekernel/Kconfig.hz
< ./arch/arm/Kconfig:sourcearch/arm/mm/Kconfig
< ./arch/blackfin/Kconfig:sourcekernel/Kconfig.hz
< ./block/Kconfig:sourceblock/Kconfig.iosched
< ./security/Kconfig:sourcesecurity/selinux/Kconfig
Quoted 1 line
better to keep them consistent
Agree - but on the other hand we do not want an all-over-the-tree patch to fix it up.
If you are up to fix it then please send the patches to the relevant subsystem/arch maintainers.
When we are almost done we could let kconfig warn if "" is missing.
PS. Added [email protected]
Sam