Skip to contentSkip to conversation

TODO

PATCH In review Robert Millan 5 participants 12 messages Oct 19, 2007 – Jan 7, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 TODO

It seems the TODO is horribly outdated, so I gave it a review. I think these are already fixed. Is it correct?

Signature · 5 lines
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
TODO +2 -13
@@ -13,7 +13,7 @@
   higher priority.
 
 
-* Add more filesystems (such as jfs, xfs and reiserfs). !
+* Add more filesystems (such as jfs and reiserfs). !
 
 * Add journal playback support to ext2fs (so it will become ext3fs).
 
@@ -21,23 +21,12 @@
 
 * Add more loaders (such as NetBSD and FreeBSD). !!
 
-* Implement a more friendly installer.
-
-* Add more terminals (such as serial). !
-
-* Implement a normal mode. !!!
+* Add more terminals. !
 
 * Write a manual.
 
-* Add support for compressed files.
-
 * Add support for network devices.
 
-* Fix the graphics mode completely and improve it to support VESA
-  as well as VGA modes. !
-
 * Add a fancy menu interface which utilizes the graphics mode
   extensively with many eye-candies. This is important to beat
   GRUB legacy. :)
-
-* Audit util/powerpc/ieee1275/grub-mkimage.c for endianness fixes.
#1 lore raw
Quoted 2 lines · Robert Millan

It seems the TODO is horribly outdated, so I gave it a review. I think these are already fixed. Is it correct?

You are right, this file is outdated. Many things have been implemented already. Now we use the TODO on the wiki, which is also outdated.

--
Marco

#2 lore raw
Quoted 8 lines · Marco Gerards
Quoted 2 lines · Robert Millan

It seems the TODO is horribly outdated, so I gave it a review. I think these are already fixed. Is it correct?

You are right, this file is outdated. Many things have been implemented already. Now we use the TODO on the wiki, which is also outdated.

Should the TODO in CVS be updated with my patch, or removed altogether?

Signature · 5 lines
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
#3 lore raw
Quoted 11 lines · Robert Millan
Quoted 7 lines · Marco Gerards
Quoted 2 lines · Robert Millan

It seems the TODO is horribly outdated, so I gave it a review. I think these are already fixed. Is it correct?

You are right, this file is outdated. Many things have been implemented already. Now we use the TODO on the wiki, which is also outdated.

Should the TODO in CVS be updated with my patch, or removed altogether?

Perhaps add reference to Wiki page. And update Wiki ;)

#4 lore raw
Quoted 2 lines · Vesa Jääskeläinen
Quoted 1 line

Should the TODO in CVS be updated with my patch, or removed altogether?

Perhaps add reference to Wiki page. And update Wiki ;)

That makes you have a network connection to have a look at it. I personally would like to be able to find it in the source.

Signature · 3 lines
Jordi Mallach Pérez  --  Debian developer     http://www.debian.org/
[email protected]     [email protected]     http://www.sindominio.net/
GnuPG public key information available at http://oskuro.net/
#5 lore raw
Quoted 6 lines · Jordi Mallach
Quoted 2 lines · Vesa Jääskeläinen
Quoted 1 line

Should the TODO in CVS be updated with my patch, or removed altogether?

Perhaps add reference to Wiki page. And update Wiki ;)

That makes you have a network connection to have a look at it. I personally would like to be able to find it in the source.

Current grub 2 development information is based on Wiki at the moment, please download notes from there. Once central place for the information is essential so there is even a chance that it is up-to-date.

#6 lore raw
In reply to Jordi Mallach
Quoted 6 lines · Jordi Mallach
Quoted 2 lines · Vesa Jääskeläinen
Quoted 1 line

Should the TODO in CVS be updated with my patch, or removed altogether?

Perhaps add reference to Wiki page. And update Wiki ;)

That makes you have a network connection to have a look at it. I personally would like to be able to find it in the source.

But you also need a network connection to get the source. How is that different from the wiki? (you can retrieve offline copies of the wiki, too ;-))

Signature · 5 lines
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
#7 lore raw
In reply to Robert Millan

What do we do about this? Keep updating the TODO file or get rif of it?

Quoted 52 lines · Robert Millan

It seems the TODO is horribly outdated, so I gave it a review. I think these are already fixed. Is it correct?

Signature · 5 lines
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
TODO +2 -13
@@ -13,7 +13,7 @@
   higher priority.
 
 
-* Add more filesystems (such as jfs, xfs and reiserfs). !
+* Add more filesystems (such as jfs and reiserfs). !
 
 * Add journal playback support to ext2fs (so it will become ext3fs).
 
@@ -21,23 +21,12 @@
 
 * Add more loaders (such as NetBSD and FreeBSD). !!
 
-* Implement a more friendly installer.
-
-* Add more terminals (such as serial). !
-
-* Implement a normal mode. !!!
+* Add more terminals. !
 
 * Write a manual.
 
-* Add support for compressed files.
-
 * Add support for network devices.
 
-* Fix the graphics mode completely and improve it to support VESA
-  as well as VGA modes. !
-
 * Add a fancy menu interface which utilizes the graphics mode
   extensively with many eye-candies. This is important to beat
   GRUB legacy. :)
-
-* Audit util/powerpc/ieee1275/grub-mkimage.c for endianness fixes.

_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel

Signature · 5 lines
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
#8 lore raw
Quoted 1 line · Robert Millan

What do we do about this? Keep updating the TODO file or get rif of it?

Personally, I think it is easier to just point to another place, such as "Please look at this URL.", using the wiki (or an issue tracker, if you prefer).

Thanks,
Okuji

#9 lore raw
Quoted 6 lines · Yoshinori K. Okuji
Quoted 1 line · Robert Millan

What do we do about this? Keep updating the TODO file or get rif of it?

Personally, I think it is easier to just point to another place, such as "Please look at this URL.", using the wiki (or an issue tracker, if you prefer).

Ok, I propose replacing it with:

<cut here>
Before working on improving GRUB, it's very important that you make contact with the core GRUB developers. Things herein might be slightly out of date or otherwise not easy to understand at first glance. So write to <[email protected]> first.

For bug tracking, refer to:

http://savannah.gnu.org/bugs/?group=grub

Our wiki also lists some areas that need work:

http://grub.enbug.org/
</cut here>

Signature · 5 lines
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
#10 lore raw
Quoted 16 lines · Robert Millan
Quoted 6 lines · Yoshinori K. Okuji
Quoted 1 line · Robert Millan

What do we do about this? Keep updating the TODO file or get rif of it?

Personally, I think it is easier to just point to another place, such as "Please look at this URL.", using the wiki (or an issue tracker, if you prefer).

Ok, I propose replacing it with:

<cut here>
Before working on improving GRUB, it's very important that you make contact with the core GRUB developers. Things herein might be slightly out of date or otherwise not easy to understand at first glance. So write to <[email protected]> first.

Quoted 8 lines

For bug tracking, refer to:

http://savannah.gnu.org/bugs/?group=grub

Our wiki also lists some areas that need work:

http://grub.enbug.org/
</cut here>

This sounds like a good idea to me.

--
Marco

#11 lore raw
Quoted 20 lines · Marco Gerards
Quoted 18 lines · Robert Millan
Quoted 6 lines · Yoshinori K. Okuji
Quoted 1 line · Robert Millan

What do we do about this? Keep updating the TODO file or get rif of it?

Personally, I think it is easier to just point to another place, such as "Please look at this URL.", using the wiki (or an issue tracker, if you prefer).

Ok, I propose replacing it with:

<cut here>
Before working on improving GRUB, it's very important that you make contact with the core GRUB developers. Things herein might be slightly out of date or otherwise not easy to understand at first glance. So write to <[email protected]> first.

For bug tracking, refer to:

Quoted 8 lines
Quoted 6 lines

http://savannah.gnu.org/bugs/?group=grub

Our wiki also lists some areas that need work:

http://grub.enbug.org/
</cut here>

This sounds like a good idea to me.

Committed then!

Signature · 5 lines
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)