Skip to contentSkip to conversation

blk_sync_queue() should cancel request_queue->unplug_work

PATCH In review Oleg Nesterov 2 participants 2 messages Oct 20, 2007 – Oct 21, 2007 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 blk_sync_queue() should cancel request_queue->unplug_work

(untested, needs an explicit ack/nack from maintainer)

blk_sync_queue() cancels the timer, but forgets to cancel the work.

block/ll_rw_blk.c renamed from block/ll_rw_blk.c~2_blk +1 -0
@@ -1723,6 +1723,7 @@ EXPORT_SYMBOL(blk_stop_queue);
 void blk_sync_queue(struct request_queue *q)
 {
 	del_timer_sync(&q->unplug_timer);
+	kblockd_flush_work(&q->unplug_work);
 }
 EXPORT_SYMBOL(blk_sync_queue);
 
#1 lore raw
Quoted 3 lines · Oleg Nesterov

(untested, needs an explicit ack/nack from maintainer)

blk_sync_queue() cancels the timer, but forgets to cancel the work.

Applied 1-2, thanks a lot Oleg.

Signature · 1 line
Jens Axboe