Skip to contentSkip to conversation

9p: v9fs_vfs_rename incorrect clunk order

PATCH In review Latchesar Ionkov 2 participants 2 messages Oct 23, 2007

Subsystems (2)
lore
Share & tools
lore

Latchesar Ionkov

author maintainer
#0 lore raw

PATCH 1/1 9p: v9fs_vfs_rename incorrect clunk order

In v9fs_vfs_rename function labels don't match the fids that are clunked. The correct clunk order is clunking newdirfid first and then olddirfid next.

---
commit 0c9269a1384273b7a409a2163fdf91cd39092889
tree 8a4984196ccb7ed027c086a53866e5582835e61f
parent 55b70a0300b873c0ec7ea6e33752af56f41250ce
author Latchesar Ionkov <[email protected]> Mon, 22 Oct 2007 18:11:19 -0600 committer Latchesar Ionkov <[email protected]> Mon, 22 Oct 2007 18:11:19 -0600

 fs/9p/vfs_inode.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
fs/9p/vfs_inode.c +2 -2
index 175b4d9..23581bc 100644
@@ -687,10 +687,10 @@ v9fs_vfs_rename(struct inode *old_dir, struct dentry *old_dentry,
 	retval = p9_client_wstat(oldfid, &wstat);
 
 clunk_newdir:
-	p9_client_clunk(olddirfid);
+	p9_client_clunk(newdirfid);
 
 clunk_olddir:
-	p9_client_clunk(newdirfid);
+	p9_client_clunk(olddirfid);
 
 done:
 	return retval;